150632 - Collecting addresses should not overwrite existing entries

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Erich 'Ricky' Iseli]

Until bug 58769 isn't fixed, it's IMHO useless to use other ABs than the
"Collected Addresses" one. Therefore I'm adding more contact infos to the cards
in the CAB but every time I get an e-mail from the person, some data gets
overwritten. This is especially true if the person didn't specify any Name and I
added the name manually. => DATALOSS

Probably there's an easy way to back out the code that checks whether some info
changed in an already existing card in the CAB. This can be checked in again
only when collecting addresses correctly sees all addresses from all ABs.

Comment 1

[Erich 'Ricky' Iseli]

Adding dep and putting Severity to critical, because of dataloss.

Comment 2

[Erich 'Ricky' Iseli]

How to reproduce this bug:
1) make sure you are collecting addresses from incoming e-mail.
2) go to the Collected Addresses and locate somebody recorded with no clear
name, but the part before the @ in his e-mail address. For example, if the
address is "[e-mail]", you should see the name listed as "my234email"
3) Get the properties of this card and set first name, last name and display
name to be the real name of the person.
4) wait until you get a new e-mail by this person
5) go back to the address book and you will see that the first name and the
display name were set to noting (empty, null) while funnily the last name is
still there.

Comment 3

[Erich 'Ricky' Iseli]

Sorry for the spam, I'm still experimenting...

Another way to reproduce is if the person provides a name different than the one
you've set. Imagine someone has the name set to "Big Brother" or any other
nickname, and you want to have his real name, say "John Smith", it will always
get overwritten with "Big Brother".

I can imagine that this is no bug _provided_ the collecting works OK (which
isn't now because of bug 58769). In fact, if somebody changes his name, I'd be
happy to see the change happen in the collected addresses, and the cards which I
don't want to be changed, should be in the PAB or any other AB.

Comment 4

[Erich 'Ricky' Iseli]

Handy for reproducing this bug, instead of waiting for the person sending you
another e-mail, just open one of those e-mails (with the "broken" name).

Comment 5

[Mike Fedyk]

Can someone please add "dataloss" to the keyword list?  Thanks

Comment 6

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 7

[Mark Banner (:standard8)]

Removing an incorrect dependency on bug 35837 - I can't see why these got 
linked in the first place.

Comment 8

[Karsten Düsterloh]

*** Bug 168952 has been marked as a duplicate of this bug. ***

Comment 9

[Greg Colyer]

I agree with [the implication of] comment #3, that the action should be on bug
58769 and not the present one.

In which case, "should not" should be removed from the present Summary.

Comment 10

[Mark Banner (:standard8)]

*** Bug 320689 has been marked as a duplicate of this bug. ***

Comment 11

[Wayne Mery (:wsmwk)]

dupe to bug 58769?

Comment 12

[Mark Banner (:standard8)]

I fixed this in bug 409608 - we don't change the card if a name is already specified, or the email we received didn't have a display name. As its not a dupe of that bug, marking fixed as a result of bug 409608.