1506424 - Can't unselect a job by clicking on or near a push's commit messages.

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

STR:
1) Load https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Crunning%2Cpending%2Crunnable&tier=1%2C2%2C3&group_state=expanded&revision=69f750237e3744322d49179c348a6b409924ed5c&selectedJob=211055260
2) Try to unselect the selected job by clicking either on the push's commit messages or in the whitespace to the right of the commit messages.

Expected:
The job is unselected, just like if you were to click in the whitespace below the commit messages, or any other whitespace on the page.

Actual:
The job remains selected.

I can't remember if this worked in the past before all of the various switches to React.

Comment 1

[Cameron Dawson [:camd]]

You know, the logic to select which clicks clears the selected job is flawed.  I have a better idea.  :)

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4269

Comment 3

[Cameron Dawson [:camd]]

I had the on-duty sheriff test this and they said it worked in the places she expected it to.  :)  Wes, if you get a chance to test it locally, that'd be awesome.  It worked great for me, fwiw.  :)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Seems to work for me.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a9c2dedf0a13d4167cc677c117d05c2122d3f90d
Bug 1506424 - Fix logic to unselect job by clicking open areas (#4269)

Comment 6

[Ed Morley [:emorley]]

This is now deployed in production.