1472717 - Selected job no longer deselected when clicking somewhere else

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Jan de Mooij [:jandem]]

This probably regressed within the last 3 days or so.

I think it still works when clicking certain areas but it doesn't work everywhere.

Comment 1

[Ed Morley [:emorley]]

Thank you for filing. I'm presuming this is due to bug 1450022.

Comment 2

[Phil Ringnalda (:philor)]

Within the display of the results of a push (where everyone would think to click to deselect), the only spot that works is in whitespace below the level of the bottom line of results or the bottom line of push information, whichever is taller. That's such a narrow strip that I only accidentally hit it, so I thought it was just intermittently working and mostly not working, rather than being a tiny little strip at the bottom which actually works 100% of the time.

The workaround is easy, but very hard to retrain yourself to use: click in the grey "get next: | 10 | 20 | 50 |" bar.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3753

Comment 4

[Cameron Dawson [:camd]]

I believe this will add clearing it back into the right places.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/1bf2e61f975a29b8153f3f3eec072db003f1f3f1
Bug 1472717 - Fix clear selected job when clicking away (#3753)

Comment 6

[Jan de Mooij [:jandem]]

Thanks for fixing so quickly!

Comment 7

[Andreea Pavel [:apavel]]

(In reply to Jan de Mooij [:jandem] from comment #0)
> This probably regressed within the last 3 days or so.
> 
> I think it still works when clicking certain areas but it doesn't work
> everywhere.

For me it still works like this. Does this need to be deployed?

Comment 8

[Ed Morley [:emorley]]

This change was deployed ~24 hours ago (see "What's deployed" link in the Treeherder help menu for which changes are awaiting deployment). Testing prod now it works fine for me.

If after refreshing the page (if it's a tab that's been open from before the deploy) the issue still occurs, please give full STR (there may be a specific region of the page that isn't working).

Comment 9

[Andreea Pavel [:apavel]]

The tab was opened about 3h ago. 

Aryx: can you please check to see if it works as expected for you? might, indeed, be something on my side.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Closing by clicking elsewhere or on the job details pane's close button works here but only if there is no job in the pinboard.

Comment 11

[Phil Ringnalda (:philor)]

Not "anywhere" else, only "anywhere which is either to the right of a job, or to the left of a job and below the list of pushes." With a single push and a lot of jobs showing, that makes a huge target, but with a merge and only unstarred showing and only a couple of jobs still left, the space to the right of the list of pushes is a large percentage of the empty space.

As long a nobody stars the one unstarred and ruins my example, the only two places you can click to deselect https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=bf624413028d403f46a90c85bffdaa2aa5791729&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-classifiedState=unclassified&selectedJob=186246991 are in the line directly to the right of the p and in the narrow blank line below the ...and more at the bottom of the list of pushes.

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3762

Comment 13

[Cameron Dawson [:camd]]

Dang, my apologies for missing these areas.  This new PR should cover that, plus the area below the "fetch more pushes" bar.

Comment 14

[Ed Morley [:emorley]]

Comment on attachment 8990083 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3762

Many thanks :-)

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3ce79a93a74ab2bbfd041d7270fa30a2f6379590
Bug 1472717 - Add more click-to-clear-job targets (#3762)