1506440 - Align SeaMonkey mailnews source structure with Thunderbird

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1453046 +++

As mentioned in Bug 1453046 Comment 1 the source structure in mailnews should be aligned too to make further porting especially the rdf removal easier.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1506440-mailnewsstructure.patch

Tested and working in 2.57 but mailnews is still broken of course.

Two things which might need further consideration:
1.) I renamed mailnews to mail. I always found it confusing with /mailnews. 
2.) I opted for the same structure as Tb but this is somewhat deep now with base. I already moved modules up but I think this should not go under base but maybe we want to eliminate base here and move everything in base up one level.

Comment 2

[Ian Neal]

Comment on attachment 9024279 [details] [diff] [review]
1506440-mailnewsstructure.patch

(In reply to Frank-Rainer Grahl (:frg) from comment #1)
> Created attachment 9024279 [details] [diff] [review]
> 1506440-mailnewsstructure.patch
> 
> Tested and working in 2.57 but mailnews is still broken of course.
> 
> Two things which might need further consideration:
> 1.) I renamed mailnews to mail. I always found it confusing with /mailnews. 
> 2.) I opted for the same structure as Tb but this is somewhat deep now with
> base. I already moved modules up but I think this should not go under base
> but maybe we want to eliminate base here and move everything in base up one
> level.

1) mailnews makes more sense to me than mail as it is about more than just mail (e.g. news groups, news feeds), another option could be messenger
2) I know we currently use base under suite, but I agree we could eliminate base here. Should mac, win and unix be moved under the content/ folder though?

Can components/preferences become components/prefs though?

f+ for the moment as I would like to see the next patch revision

Comment 3

[Stefan [:stefanh]]

Fwiw, I vote for keeping mailnews.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1506440-mailnewsstructure.patch

> 1) mailnews makes more sense to me than mail as it is about more than just mail (e.g. news groups, news feeds), another option could be messenger

As discussed on irc. Rationale was to separate it from the shared mailnews dir. It is essentialy the adapted mail part needed for suite from /mail. Lets discuss it during the next meeting. If I am the only one to think so renaming it back to mailnews will be done in a snap.

> 2) I know we currently use base under suite, but I agree we could eliminate base here. Should mac, win and unix be moved under the content/ folder though?

Eliminated base. Moved the three under content as in suite/base/content. If this should go better in a follow-up. For post esr60 it needs to go because overlays are removed.

> Can components/preferences become components/prefs though?

Sure and done but: mail and browser use components/preferences. We have suite/components/pref. I would either align here in mail and name it pref or at least rename pref to prefs in a follow-up to be at least consistent within the product.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1506440-mailnewsstructure.patch

By popular demand back to mailnews. esr60 version. If r+ I will rebase for c-c

Comment 6

[Ian Neal]

Comment on attachment 9034622 [details] [diff] [review]
1506440-mailnewsstructure.patch

I was happy with your pref rather than prefs suggestion, but either way r/a=me (and for 2.53 if you want)

Comment 7

[Frank-Rainer Grahl (:frg)]

I was happy with your pref rather than prefs suggestion,

Then I change it to components/pref for checkin to be consistent in suite. Still some prefs dirs for later alignment left.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5efd0e02c927
Align SeaMonkey mailnews source structure with Thunderbird. r=IanN

Comment 9

[Frank-Rainer Grahl (:frg)]

Decided to push unchanged. We can cleanup any names like pref* later.

https://hg.mozilla.org/releases/comm-esr60/rev/dcc7eecaadb11b355337078342752af00891347c