1453046 - Move SeaMonkey suite/common/ to suite/components/

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Moving over common to components started in Bug 1428299. I would like to finish it before esr60 hits release.

+++ This bug was initially created as a clone of Bug #1428299 +++

There are a number of areas in SeaMonkey which are unnecessarily deep, one such area is suite/profile.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1453046-components.patch

Patch which moves common to components. This mostly aligns the SeaMonkey structure with Firefox and TB. No direct benefit other than that it makes locating files when porting a little easier (at least for me).

There are still a few gray areas here and in mailnews which need to be sorted out later. 

Stefanh, rsx11m:

This patch would only make sense if checked into Beta too. Otherwise we would need to rebase endlessly for ESR60. What do you think about it?

Comment 2

[Ian Neal]

Comment on attachment 8966655 [details] [diff] [review]
1453046-components.patch

>+++ b/suite/components/moz.build

>+# DEFINES for preprocessing
>+# Use suite/common/app-license.html as input when generating 
Comment needs updating

I'm not happy with the amount of files sitting in the root of suite/components
Do we need a suite/base/content or similar?
Do we need additional sub-directories under suite/components? e.g. about, sessionstore

Also files under suite/components/src and suite/components/public should be found new homes

f+ as a good start but needs some fine tuning

Comment 3

[rsx11m]

Comment on attachment 8966655 [details] [diff] [review]
1453046-components.patch

In general I'm fine with that. There is a top-level common/ in comm-central already, and the distinction between suite/common and suite/components isn't quite clear to me. Thus, cleaning up potential points of confusion is certainly helpful.

I'm wondering though if suite/locales/en-US/chrome/common needs corresponding modifications for consistency?

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1453046-components-V2.patch

Just a rebase to take care of the latest changes. If/When I find some time I will see if I can address the feedback and fine tune it further.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1453046-components-V3.patch

This should be already reviewable but I didn't test on 2.53 to see if everything works. Builds fine. I compared the comm.manifest files between comm-central and comm-esr60. There were identical and packaging also works.
communicator Chrome directories also compared ok.

Restored the jar.mn for sync because it is now in its own directory and not used.
Deleted the obsolete nsSuiteDownloadHelper.

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1453046-components-V4.patch

rebase after downloads was moved in Bug 888915

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 1453046-components-V5.patch

Looking at the patch I realized that common/moz.build and common/jar.mn ended mostly in base so copy and change them to retain history.

Comment 8

[Ian Neal]

Comment on attachment 8983512 [details] [diff] [review]
1453046-components-V5.patch

LGTM r=me

Comment 9

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8983512 [details] [diff] [review]
1453046-components-V5.patch

Given the state of the c-c tree we need it directly in esr60

Comment 10

[Ian Neal]

Comment on attachment 8983512 [details] [diff] [review]
1453046-components-V5.patch

a=me

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0838548ddc02
Move SeaMonkey suite/common/ to suite/components/ and suite/base. r=IanN

Comment 12

[Frank-Rainer Grahl (:frg)]

Minor rebase for esr60
https://hg.mozilla.org/releases/comm-esr60/rev/d9de214a5af909728bc10383a9e76c19fdcb230a

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58b1612f62fe
Add missing new nsSessionStartup.manifest to SeaMonkey. r=me

Comment 14

[Frank-Rainer Grahl (:frg)]

Missed one new manifest file from the shuffle around:
https://hg.mozilla.org/releases/comm-esr60/rev/ea52dfa90ab1e256e23fa2a30ad4653b566f41db

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f41b1b22aeba
Remove duplicate SuiteProfileMigrator.manifest from SeaMonkey installer. r=me

Comment 16

[Frank-Rainer Grahl (:frg)]

This was hopefully the last problem resulting from the move.

https://hg.mozilla.org/releases/comm-esr60/rev/8ac513363c1b713a631a6d8720705948f9b633dc