1506457 - [Display bug] Full screen private windows top right icon is duplicate

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[yvan.sraka]

Attachment: Screenshot 2018-11-11 at 16.07.55.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

Just open a new private windows in full screen mode on macOS (the bug also occurs if the private window is not open in full screen and put after full screen).


Actual results:

The top right "private windows" icon is duplicated (see screenshot attached)!

If we put the windows back in normal mode (not full screen) the duplicate icon disappear.



Expected results:

The top right icon should not be duplicated in full screen mode.

Comment 1

[ovidiu boca[:Ovidiu]]

I tested this on the Nightly 65.0a1(2018-11-14) and I can reproduce it. I also tested it with FF release 63 and Beta 64 and I can't reproduce it, this is a regression.

Here is the push log:
Last good revision: 1ab00b6e99fd65b651381c235f1ae95ed746e57a
42:29.61 INFO: First bad revision: e354a018b703c453e8afcda1f44f1d51456536f5
42:29.61 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1ab00b6e99fd65b651381c235f1ae95ed746e57a&tochange=e354a018b703c453e8afcda1f44f1d51456536f5

Mike, please look at this, seems that bug 1356920 introduced this regression. Thanks

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Thanks, taking.

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Attachment: Bug 1506457 - Only show titlebar indicators in the titlebar-secondary-buttonbox on macOS. r?dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b441356e337
Only show titlebar indicators in the titlebar-secondary-buttonbox on macOS. r=dao

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1b441356e337

Comment 6

[Daniel Cicas [:dcicas], Release QA]

I reproduced this issue using Fx 65.0a1, build ID: 20181111100236, on MacOS 10.13.

I can confirm this issue is verified as fixed using Fx 65.0b6, build ID: 20181220174318, on macOS X 10.13.