Port bug 1505801 to TB: Use --lwt-accent-color behind --toolbar-bgcolor in the find bar background

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 65.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

With a dark LW-theme, not the dark theme, the findbar has white text on a light background.
Posted patch 1506465-findbar.patch (obsolete) — Splinter Review
As wrote in comment 0, try a LW-theme with dark background and light text to see the bug.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9024309 - Flags: review?(jorgk)
Comment on attachment 9024309 [details] [diff] [review]
1506465-findbar.patch

Like "Dark Fox"? The Ctrl+F findbar has light text on pink background if the words isn't found. As long as it's found, it's black on white. With the patch I get white on darker magenta if not found. That's the intent, yes?
Attachment #9024309 - Flags: review?(jorgk) → review+
Posted image findbar.png
No, I meant the white "Highlight All, Match Case, Whole Words" on the grey background on the right of the textbox. With the patch it's a dark background.
Keywords: checkin-needed
Found a '+' in Mac file from copy/paste, removed.
Attachment #9024309 - Attachment is obsolete: true
Attachment #9024319 - Flags: review+
(In reply to Richard Marti (:Paenglab) from comment #3)
> No, I meant the white "Highlight All, Match Case, Whole Words" on the grey
> background on the right of the textbox.
They were completely invisible that's why I didn't see them ;-( - Now it's fine.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f7517410336f
Port bug 1505801: Use --lwt-accent-color behind --toolbar-bgcolor in the find bar background. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.