1506504 - Add/fix keyboard behaviour for buttons which open PanelMultiView popup panels

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[James Teh [:Jamie]]

Bug 1436086 will make it possible to navigate to and activate all browser toolbar buttons from the keyboard. We need to add keyboard support for the various buttons which open popup panels. Bug 1506503 will implement specific keyboard support for PanelMultiView so that activating popup panels from the keyboard will focus their first item, so we want to use this for all of these buttons.

Specifically, this will add keyboard support for the Library and Page Actions buttons. It also fixes the Firefox menu button keyboard handling so that it only handles space and enter, rather than incorrectly activating for *all* key presses.

Comment 1

[Graham Perrin]

What if a text entry field is something other than the first item?

Comment 2

[Yuri Khan]

(In reply to Graham Perrin from comment #1)
> What if a text entry field is something other than the first item?

Nothing special. Most of the time, a popup plays the role of either a popup menu or a dialog box. In traditional GUIs, text entry fields are extremely rare in popup menus, and often present in dialog boxes in a position other than the first, but the focus is normally set to the first focusable item, or, sometimes, to the first focusable leaf item (e.g. in case of a tab group, to the first item in the first tab).

One specific case of a UI where a text entry field is located below a different item but must be focused first is a command line or chat interface (log + command/new message line + Execute/Send button), but how often do you want to put these in a popup panel?

(Of course there could be an opt-in provision for extension authors that they could mark any one of their panel items with the autofocus attribute and then that would be the one focused if their panel is activated by a keyboard action.)

Comment 3

[James Teh [:Jamie]]

To clarify, for the purposes of this bug, I'm only talking about popup panels managed by PanelMultiView.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1506504: Add/fix keyboard behaviour for browser toolbar buttons which open popups.

1. Fix the Firefox menu button so that it only handles space and enter, rather than incorrectly activating for *all* key presses.
2. Add keyboard support (space and enter) for the Library and page Actions buttons.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb3f227c4f29
Add/fix keyboard behaviour for browser toolbar buttons which open popups. r=Gijs

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fb3f227c4f29