Add/fix keyboard behaviour for buttons which open PanelMultiView popup panels

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: Jamie, Assigned: Jamie)

Tracking

(Blocks 1 bug)

unspecified
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Bug 1436086 will make it possible to navigate to and activate all browser toolbar buttons from the keyboard. We need to add keyboard support for the various buttons which open popup panels. Bug 1506503 will implement specific keyboard support for PanelMultiView so that activating popup panels from the keyboard will focus their first item, so we want to use this for all of these buttons.

Specifically, this will add keyboard support for the Library and Page Actions buttons. It also fixes the Firefox menu button keyboard handling so that it only handles space and enter, rather than incorrectly activating for *all* key presses.

Comment 1

6 months ago
What if a text entry field is something other than the first item?

Comment 2

6 months ago
(In reply to Graham Perrin from comment #1)
> What if a text entry field is something other than the first item?

Nothing special. Most of the time, a popup plays the role of either a popup menu or a dialog box. In traditional GUIs, text entry fields are extremely rare in popup menus, and often present in dialog boxes in a position other than the first, but the focus is normally set to the first focusable item, or, sometimes, to the first focusable leaf item (e.g. in case of a tab group, to the first item in the first tab).

One specific case of a UI where a text entry field is located below a different item but must be focused first is a command line or chat interface (log + command/new message line + Execute/Send button), but how often do you want to put these in a popup panel?

(Of course there could be an opt-in provision for extension authors that they could mark any one of their panel items with the autofocus attribute and then that would be the one focused if their panel is activated by a keyboard action.)
(Assignee)

Comment 3

6 months ago
To clarify, for the purposes of this bug, I'm only talking about popup panels managed by PanelMultiView.
Summary: Add/fix keyboard behaviour for buttons which open popup panels → Add/fix keyboard behaviour for buttons which open PanelMultiView popup panels
(Assignee)

Comment 4

6 months ago
1. Fix the Firefox menu button so that it only handles space and enter, rather than incorrectly activating for *all* key presses.
2. Add keyboard support (space and enter) for the Library and page Actions buttons.
Priority: -- → P1
(Assignee)

Updated

6 months ago
Depends on: 1506787
(Assignee)

Updated

6 months ago
Blocks: 1509767

Comment 5

5 months ago
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3f227c4f29
Add/fix keyboard behaviour for browser toolbar buttons which open popups. r=Gijs

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fb3f227c4f29
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.