Keyboard activation (space/enter) of Back/Forward buttons when focused

RESOLVED FIXED in Firefox 66

Status

()

defect
P1
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: Jamie, Assigned: Jamie)

Tracking

(Blocks 1 bug)

unspecified
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
When made focusable (for toolbar keyboard navigation), the Back and Forward buttons cannot be activated by pressing space or enter. Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses. Changing this for type="menu" is controversial at best, since space should arguably open the menu in this case (and I think it does on the Mac). Because the Back/Forward buttons have a bit of an identity crisis in this respect, I think it's best to just implement keyboard behaviour specifically for these buttons.
(Assignee)

Comment 1

5 months ago
When focused, the Back and Forward buttons previously couldn't be activated by pressing space or enter.
Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses by default.
Since these buttons are special (in that they have type="menu" and a command event), this change implements specific keyboard behavior for these buttons.
(Assignee)

Updated

5 months ago
Depends on: 1506504
Assignee: nobody → jteh
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 2

4 months ago
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbaf671d5e84
Support keyboard activation (space/enter) of the Back/Forward buttons when focused. r=Gijs

Comment 3

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dbaf671d5e84
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.