47 bytes, text/x-phabricator-request
|Details | Review|
When made focusable (for toolbar keyboard navigation), the Back and Forward buttons cannot be activated by pressing space or enter. Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses. Changing this for type="menu" is controversial at best, since space should arguably open the menu in this case (and I think it does on the Mac). Because the Back/Forward buttons have a bit of an identity crisis in this respect, I think it's best to just implement keyboard behaviour specifically for these buttons.
When focused, the Back and Forward buttons previously couldn't be activated by pressing space or enter. Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses by default. Since these buttons are special (in that they have type="menu" and a command event), this change implements specific keyboard behavior for these buttons.
Assignee: nobody → jteh
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/dbaf671d5e84 Support keyboard activation (space/enter) of the Back/Forward buttons when focused. r=Gijs
You need to log in before you can comment on or make changes to this bug.