1509767 - Keyboard activation (space/enter) of Back/Forward buttons when focused

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[James Teh [:Jamie]]

When made focusable (for toolbar keyboard navigation), the Back and Forward buttons cannot be activated by pressing space or enter. Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses. Changing this for type="menu" is controversial at best, since space should arguably open the menu in this case (and I think it does on the Mac). Because the Back/Forward buttons have a bit of an identity crisis in this respect, I think it's best to just implement keyboard behaviour specifically for these buttons.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1509767: Support keyboard activation (space/enter) of the Back/Forward buttons when focused.

When focused, the Back and Forward buttons previously couldn't be activated by pressing space or enter.
Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses by default.
Since these buttons are special (in that they have type="menu" and a command event), this change implements specific keyboard behavior for these buttons.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbaf671d5e84
Support keyboard activation (space/enter) of the Back/Forward buttons when focused. r=Gijs

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/dbaf671d5e84