RootFront.listWorkers should return WorkerTargetFront rather than JSON forms

RESOLVED FIXED in Firefox 65

Status

enhancement
P2
normal
RESOLVED FIXED
6 months ago
2 days ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 65
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(3 attachments)

Assignee

Description

6 months ago
Today, WorkerTargetFront is instantiated by TargetFactory.forWorker callsites like this one:
https://searchfox.org/mozilla-central/rev/06d5d5ae4396be85f26e8548323ee6c12e7bce4e/devtools/client/debugger/new/panel.js#71-73
    const [response, workerTargetFront] =
      await this.toolbox.target.client.attachWorker(worker.actor);
    const workerTarget = TargetFactory.forWorker(workerTargetFront);

But we should rather let protocol.js auto-marshalling instantiate all the fronts, here, during RootFront.listWorkers request.
Assignee

Updated

6 months ago
Assignee: nobody → poirot.alex
Assignee

Comment 2

6 months ago
MozReview-Commit-ID: 8FZbi4KQzCn

Depends on D11761
Assignee

Comment 3

6 months ago
MozReview-Commit-ID: 4CBQNwC8tKq

Depends on D11762

Comment 5

6 months ago
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a421a0addad
Remove last references to remote targets from target.js. r=yulia
https://hg.mozilla.org/integration/autoland/rev/fc303dfddb35
Prevent displaying memory and netmonitor panels for workers. r=yulia
https://hg.mozilla.org/integration/autoland/rev/d279007bde1a
Return WorkerTargetFront from listWorkers instead of form. r=yulia

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a421a0addad
https://hg.mozilla.org/mozilla-central/rev/fc303dfddb35
https://hg.mozilla.org/mozilla-central/rev/d279007bde1a
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee

Updated

6 months ago
Depends on: 1509315
Assignee

Updated

6 months ago
No longer depends on: 1509315
You need to log in before you can comment on or make changes to this bug.