1506548 - RootFront.listWorkers should return WorkerTargetFront rather than JSON forms

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Today, WorkerTargetFront is instantiated by TargetFactory.forWorker callsites like this one:
https://searchfox.org/mozilla-central/rev/06d5d5ae4396be85f26e8548323ee6c12e7bce4e/devtools/client/debugger/new/panel.js#71-73
    const [response, workerTargetFront] =
      await this.toolbox.target.client.attachWorker(worker.actor);
    const workerTarget = TargetFactory.forWorker(workerTargetFront);

But we should rather let protocol.js auto-marshalling instantiate all the fronts, here, during RootFront.listWorkers request.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506548 - Remove last references to remote targets from target.js.

MozReview-Commit-ID: 1viBxZ8hHGk

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506548 - Prevent displaying memory and netmonitor panels for workers.

MozReview-Commit-ID: 8FZbi4KQzCn

Depends on D11761

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506548 - Return WorkerTargetFront from listWorkers instead of form.

MozReview-Commit-ID: 4CBQNwC8tKq

Depends on D11762

Comment 4

[Alexandre Poirot [:ochameau]]

Green try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=41640526b0a0a0383e8f4830564ce620cb5c73bd

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a421a0addad
Remove last references to remote targets from target.js. r=yulia
https://hg.mozilla.org/integration/autoland/rev/fc303dfddb35
Prevent displaying memory and netmonitor panels for workers. r=yulia
https://hg.mozilla.org/integration/autoland/rev/d279007bde1a
Return WorkerTargetFront from listWorkers instead of form. r=yulia

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8a421a0addad
https://hg.mozilla.org/mozilla-central/rev/fc303dfddb35
https://hg.mozilla.org/mozilla-central/rev/d279007bde1a