1506627 - Selecting lines and then scrolling out of view (e.g. to select more than screen can display) prevents copying selected text

Status: NEW

(Tree Management :: Treeherder, enhancement, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If one selects more lines than the screen can display and then tries to copy it, the clipboard will not contain all of the selected line but the last ones will be missing.

Steps to reproduce:
1. Go to https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=211191928&repo=autoland&lineNumber=2980
2. Select from the TEST-START to the end of the crashing thread (lines 2973-3124).
Scroll up and down to lose the selection or hit Ctrl+C and try to paste it somewhere. The not visible part will be gone.

Comment 1

[Ed Morley [:emorley]]

Hi :-)

We're using react-lazylog now, so this is likely something that will need to be fixed over there (since I'm guessing it's not related to the way we're integrating it).

I've filed:
https://github.com/mozilla-frontend-infra/react-lazylog/issues/24

Comment 2

[Cameron Dawson [:camd]]

I commented in the github issue for when more information/a fix is available.

Comment 4

[Cameron Dawson [:camd]]

I tried the suggestions in the github issue to increase the overscanRowCount, but that didn't help with selecting. It keeps changing what's selected as the scroll window changes. This is true, even when you only select 10 lines (well within the 100 line overscan size).

I think this can only be addressed upstream. Moving to P5 in case someone wants to follow up on this.

At this point the best way to select a set of lines larger than the window is to go to the raw log.

Comment 5

[Cosmin Sabou [:CosminS]]

Cameron, think you could have another go at this? It would mean a lot for the sheriffs when filing new bugs and anyone copying lines from the parsed logs. Thank you.

Comment 6

[Cameron Dawson [:camd]]

I've poked around a bit looking for options and no "trivial" fix comes to mind. But I wonder if we just created a separate viewer that loads raw lines from the line in question. It defaults to getting 100 lines, but you click another button and it reads the next 100 lines in either direction. Not overly elegant, but it would get you the data you want. I'll spend an hour or so exploring that idea.

Comment 7

[Cosmin Sabou [:CosminS]]

Thank you for looking into this.

Comment 8

[Cameron Dawson [:camd]]

I won't be able to get to this anytime soon. Hopefully we can find another dev to take a look.

Comment 9

[Suyash Salampuria]

(In reply to Ed Morley [:emorley] from comment #1)

Hi :-)

We're using react-lazylog now, so this is likely something that will need to
be fixed over there (since I'm guessing it's not related to the way we're
integrating it).

I've filed:
https://github.com/mozilla-frontend-infra/react-lazylog/issues/24

This issue has not been solved as yet
So, we can't do it at present