1535414 - Provide a mechanism to find-in-file the log when viewed in the log viewer

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder, enhancement, P5)

Description

[Kartikaya Gupta (email:[e-mail])]

The log viewer seems to do some sort of dynamic thing where it removes parts of the log not immediately visible. But this breaks ctrl-f to search for stuff. It would be nice if there was some way to do a ctrl-f type of operation on the log. I know it can be done by opening the raw log, but in this particular scenario I want to link to a specific line number so I need to find the line in the log viewer.

Comment 1

[Cameron Dawson [:camd]]

Yes, we use the react-lazy-log component which pages information in and out. We can experiment with widening the overscan on this, but it won't really fix this because it won't be a complete load.

Your best bet, if you need to do a ctrl+f kind of search is to use load the raw log.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Cameron Dawson [:camd] from comment #1)

Yes, we use the react-lazy-log component which pages information in and out. We can experiment with widening the overscan on this, but it won't really fix this because it won't be a complete load.

I was thinking along the lines of adding a little feature on the log viewer that lets you enter a search term and it will XHR back to the server to do the search and then let you navigate between occurrences. Basically reimplementing the find-in-page feature on the log viewer. I realize this might be overkill, so feel free to close as WONTFIX.

Comment 3

[Cameron Dawson [:camd]]

This sounds totally reasonable, yeah. Though I must admit I don't think anyone in-house will get to this any time soon. Though we'd be happy to accept patches for it. :) I'll mark its priority accordingly.

Thanks for the idea!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This happened at some point. I can't be bothered to track down the relevant thing to dupe this to.