1506690 - crash in java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference at org.mozilla.gecko.CrashReporterActivity.getProfileName(CrashReporterActivity.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Jan Henning [:JanH]]

+++ This bug was initially created as a clone of Bug #1483993 +++

The crash while attempting to enable startup profiling in bug 1506689 again leads to crash where the crash reporter itself crashes, too... and once again CrashReporterActivity.getProfileName() is to blame:

> 11-12 21:01:55.021 31698-31698/? E/GeckoCrashHandler: >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
>     java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
>         at org.mozilla.gecko.CrashReporterActivity.getProfileName(CrashReporterActivity.java:343)
>         at org.mozilla.gecko.CrashReporterActivity.onCreate(CrashReporterActivity.java:185)
>         at android.app.Activity.performCreate(Activity.java:6259)
>         at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1130)
>         at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2382)
>         at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2493)
>         at android.app.ActivityThread.-wrap11(ActivityThread.java)
>         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1357)
>         at android.os.Handler.dispatchMessage(Handler.java:102)
>         at android.os.Looper.loop(Looper.java:148)
>         at android.app.ActivityThread.main(ActivityThread.java:5459)
>         at java.lang.reflect.Method.invoke(Native Method)
>         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
>         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Should be able to investigate this with steps to reproduce from the related bugs.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Tried to reproduce this by starting a new app instance, after Quit-ing it with
> adb shell am start -n org.mozilla.fennec_petru.lingurar/org.mozilla.gecko.App --es env0 MOZ_PROFILER_STARTUP=1 --es env1 MOZ_PROFILER_SHUTDOWN=/sdcard/profile.json 
but was unable to.

Still, I think this should be resolved by bug 1504780 where I've added a simple null check as :snorp suggested.

Comment 3

[Jan Henning [:JanH]]

Of course it doesn't crash anymore because I fixed that bug.
For testing locally, you need to back that bug out and also add "export MOZ_CRASHREPORTER=1" to your mozconfig, maybe even also "export MOZ_OFFICIAL=1" because parts of our crash handling seem conditional on being in an official build.

However it is possible that bug 1504780 already covers the same problem.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

(In reply to Jan Henning [:JanH] from comment #3)
> Of course it doesn't crash anymore because I fixed that bug.
> For testing locally, you need to back that bug out and also add "export
> MOZ_CRASHREPORTER=1" to your mozconfig, maybe even also "export
> MOZ_OFFICIAL=1" because parts of our crash handling seem conditional on
> being in an official build.
> 
> However it is possible that bug 1504780 already covers the same problem.

I didn't get this error with or without the patch from bug 1506689 (after enabling 'Clear private data on exit', pressing to Quit and starting the app with that adb command and parameters).

So I couldn't test the patch from bug 1504780 in relation to the steps above, but given the broad range of situations that patch covers it's probable that it also resolves this situation.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Jan, do you still see the error yourself or should we count this as fixed/WFM?

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Please reopen if there is still a remaining issue.