Closed
Bug 1506770
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Broken icon for some addons for USB debugging
Categories
(DevTools :: about:debugging, defect, P1)
DevTools
about:debugging
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jdescottes, Assigned: daisuke)
References
(Blocks 1 open bug)
Details
(Whiteboard: old-remote-debugging-ng-m3)
Attachments
(2 files)
Follow up to 1506581.
From Daisuke's review:
> One issue. I added one addon (YouTube Addblock) on Android Firefox. That
> reflects to the list though, the icon does not display correctly.
> The reason is that the url of icon points to jar file on Android.
> (In above case, the url is
> jar:file:///data/user/0/org.mozilla.fennec_daisuke/files/mozilla
> /7h3nh88y.default/extensions/%7B80e9f0be-bd1e-4b69-b079-5f44b2962921%7D.xpi!
> /img/icon-64.png)
>
Some addons have an icon which points to a local image and can therefore not be displayed. I think I have also seen correct icons for some addons in USB debugging, not sure how those had their icon defined.
For the situation mentioned in the comment, we should see if we can send the image data from the debugger server, or at least display a fallback icon.
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P2
|
|
Reporter | |
Comment 1•6 years ago
|
||
filter on remote-debugging-next-move-m3-to-m2
Blocks: remote-debugging-ng-m2
|
|
Reporter | |
Comment 2•6 years ago
|
||
filter on remote-debugging-next-move-m3-to-m2
|
|
Reporter | |
Comment 3•6 years ago
|
||
filter on remote-debugging-next-move-m3-to-m2
No longer blocks: remote-debugging-ng-m3
Whiteboard: old-remote-debugging-ng-m3
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
Depends on D14368
Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f05ce909c05 Extract data url from icon of addon. r=jdescottes,ochameau https://hg.mozilla.org/integration/autoland/rev/9b088957d794 Get and use iconDataURL as icon of addon from the debugger server. r=jdescottes,ochameau
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f05ce909c05 https://hg.mozilla.org/mozilla-central/rev/9b088957d794
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•