1506878 - "Unmute tabs" and "Mute tabs" should use the same access key

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Cristian Fogel [:cfogel]]

[Note]:
- In reply to https://bugzilla.mozilla.org/show_bug.cgi?id=1497505#c5

[Affected versions]:
- 64.0b8, 65.0a1 (2018-11-12)

[Affected platforms]:
- win10, Ubuntu16.04, macOS 10.14

[Steps to reproduce]:
1. Launch Firefox;
2. Right click on the tab_name;
3. Click on the Mute option;
4. Repeat steps 2+3 (Unmute Option);

[Expected result]:
- Access keys should be one and the same for both mute / unmute option;

[Actual result]:
- current state:  Unmute ta[b]s  / M[u]te tabs.

[Regression range]:
- introduced with 1497505

Comment 1

[Cristian Fogel [:cfogel]]

*Ignore the regression note

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1506878 - Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f16a83697cc
Use the same accesskey for Unmute Tabs and Mute Tabs as we do for Unmute Tab and Mute Tab. r=dao

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1f16a83697cc

Comment 5

[Cristian Fogel [:cfogel]]

Verified with 65.0a1 (2018-11-18) on Win10, macOS10.13, Ubuntu16.04.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something you wanted to uplift to Beta?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> Is this something you wanted to uplift to Beta?

As it changes user-facing strings I didn't think it was something that *could* be uplifted. Though if we can uplift it then I would like to, yes.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Whoops, I'll admit I didn't actually look at the patch before asking that question :). You're right, uplifting is a no-go here.