1506915 - Move app update auto enabled / disabled to a jsm

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Robert Strong (they/them - no direct email)]

I noticed that telemetry checks whether app update auto is enabled or not early on. I'd like to move this code to a jsm since that instantiates the app update service which takes several ms to load due to the file size of nsUpdateService.js and is why nsUpdateServiceStub.js exists to prevent loading nsUpdateService.js during startup unless it is necessary.

Comment 1

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7da212cb64243991f2f4c893e0dcc5ad1a5e600

I'm going to wait on the results before pushing the patch to phabricator

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to try... had to fix an eslint error
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7da212cb64243991f2f4c893e0dcc5ad1a5e600

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1506915 - Move app update auto enabled / disabled to a jsm. r=bytesized,chutten

This moves getting and setting the value of app.update.auto from nsUpdateService.js to UpdateUtils.jsm so nsUpdateService.js isn't loaded during startup
Changes the browser_policy_app_update_URL.js test to check the default pref for app.update.url since the default pref is read by app update
Fixes a NS_NOINTERFACE error in app update xpcshell tests for AppInfo not implementing nsIPlatformInfo

Comment 4

[Robert Strong (they/them - no direct email)]

Filed bug 1510798 for Thunderbird
Updated bug 1501790 for Seamonkey to include these changes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4939e4a1cc20
Move app update auto enabled / disabled to a jsm. r=bytesized,chutten

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4939e4a1cc20