Closed Bug 1506949 Opened 2 years ago Closed 1 year ago

Consider using idle queue for RefreshDriver ticks after first contentful paint but before load

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

And if we do this, perhaps we could remove nglayout.initialpaint.delay
Priority: -- → P3
Summary: Consider using idle queue for RefreshDriver ticks after first non-blank-paint but before load → Consider using idle queue for RefreshDriver ticks after first contentful paint but before load
Attached patch slower_load_vsync_3.diff (obsolete) — Splinter Review

This is quite similar to bug 1339135.

This is also related to bug 1517850, which tries to ensure we get first contentful paint sooner, but after that we should slow down painting rate.

I don't have yet too good numbers, but at least in performance profiles we end up spending less time reflowing/painting the page, which should lead to faster page loads.

Attachment #9037285 - Attachment is obsolete: true
Attachment #9037810 - Flags: review?(afarre)
Comment on attachment 9037810 [details] [diff] [review]
slower_load_vsync_4.diff

Review of attachment 9037810 [details] [diff] [review]:
-----------------------------------------------------------------

Discussed a bit about if prefs would be helpful or not on irc. I'm ok without.
Attachment #9037810 - Flags: review?(afarre) → review+

This might even build.

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/840dbcc8d159
use idle queue for RefreshDriver tick betweek fcp and load, r=farre
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1524189
You need to log in before you can comment on or make changes to this bug.