Consider using idle queue for RefreshDriver ticks after first contentful paint but before load

RESOLVED FIXED in Firefox 67

Status

()

P3
normal
RESOLVED FIXED
3 months ago
24 days ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

And if we do this, perhaps we could remove nglayout.initialpaint.delay
Priority: -- → P3
Blocks: 1511790
Summary: Consider using idle queue for RefreshDriver ticks after first non-blank-paint but before load → Consider using idle queue for RefreshDriver ticks after first contentful paint but before load

Created attachment 9037285 [details] [diff] [review]
slower_load_vsync_3.diff

Created attachment 9037810 [details] [diff] [review]
slower_load_vsync_4.diff

This is quite similar to bug 1339135.

This is also related to bug 1517850, which tries to ensure we get first contentful paint sooner, but after that we should slow down painting rate.

I don't have yet too good numbers, but at least in performance profiles we end up spending less time reflowing/painting the page, which should lead to faster page loads.

Attachment #9037285 - Attachment is obsolete: true
Attachment #9037810 - Flags: review?(afarre)
Comment on attachment 9037810 [details] [diff] [review]
slower_load_vsync_4.diff

Review of attachment 9037810 [details] [diff] [review]:
-----------------------------------------------------------------

Discussed a bit about if prefs would be helpful or not on irc. I'm ok without.
Attachment #9037810 - Flags: review?(afarre) → review+

Created attachment 9039641 [details] [diff] [review]
slower_load_vsync_5.diff

This might even build.

Comment 7

25 days ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/840dbcc8d159
use idle queue for RefreshDriver tick betweek fcp and load, r=farre

Comment 8

25 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 25 days ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1524207
You need to log in before you can comment on or make changes to this bug.