1507126 - [remote-dbg-next] Support for several USB devices connected simultaneously

Status: VERIFIED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes] (PTO 20 oct -> 25 oct)]

STRs:
- on device A with firefox for android, enable USB debugging and connect to the computer via USB
- same on another device
- enable new about:debugging, make sure ADB extension is installed
- open about:debugging
=> Check what happens in about:debugging in this situation:
- are both devices visible in the sidebar?
- can you connect to both devices simultaneously?

So far we have only tested one USB device connected at a time. We need to check what happens if we attempt to connect more than one. If there are limitations, we will file follow up bugs to address them.

Comment 1

[Julian Descottes [:jdescottes] (PTO 20 oct -> 25 oct)]

Please test

Comment 2

[mcroud]

Here is a list of actions and results when testing simultaneously a:
- Moto G(4) Android 7.0
- Galaxy Tab 4 Android 5.0.2

As suggested by Harald in the document, this may be a driver issue so I shall revisit these two devices again once I have downloaded the extra drivers.

https://docs.google.com/document/d/1g59CqIHU_sClTdwv_-pnHU9hahobMaMSoLEMcmBFi9A/edit?usp=sharing

Comment 3

[Daisuke Akatsuka (:daisuke)]

I have tested two Pixel 2 (Android 8.1.0)  with m-c of today.
Then have connected both devices via USB (and the setup for debugging).

As conclude, the sidebar does not display any devices at all in my environment.
And an error was occurred:
`JavaScript error: , line 0: uncaught exception: BAD_RESPONSE`
But there was no information where does the error come from.
We need to investigate.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1507126: Execute adb shell command to specified device. r=jdescottes!

Depends on D14313

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1507126: Prepare port forwarding for specified device. r=jdescottes!

Depends on D14708

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1507126: Corresponds to USB device disconnection. r?jdescottes

Depends on D14709

So far, because we supported only single device, we could correspond to
disconnection by following code. From now, because we will support multi
devices, fix the code that changes the status.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3443db213424
Execute adb shell command to specified device. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/8b4fdcb28dbf
Prepare port forwarding for specified device. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/67c2abcdadaf
Corresponds to USB device disconnection. r=jdescottes

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3443db213424
https://hg.mozilla.org/mozilla-central/rev/8b4fdcb28dbf
https://hg.mozilla.org/mozilla-central/rev/67c2abcdadaf

Comment 10

[Liviu Seplecan]

Verified on several machines: Windows 10, MAC OS X, Ubuntu 16.04 using following devices: Xiaomi Pocophone F1 / Sony Xperia X. Both devices could be connected simultaneously.