1507368 - Use constants defined in util/Unicode.h in CharacterEncoding.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

there are  raw numbers for surrogate etc.
they should be replaced with constants (LeadSurrogateMin etc).

Comment 1

[Tooru Fujisawa [:arai]]

here's links
https://searchfox.org/mozilla-central/source/js/src/vm/CharacterEncoding.cpp
https://searchfox.org/mozilla-central/source/js/src/util/Unicode.h

Comment 2

[Tooru Fujisawa [:arai]]

also links for SpiderMonkey build documentation
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation

Comment 3

[Hamzah Akhtar]

Attachment: Bug 1507368 - Use constants defined in util/Unicode.h in CharacterEncoding.cpp

Replacing values defined as constants in Unicode.h in the CharacterEncoding.cpp file

Comment 4

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03272a0ec008df08b85c87e4ca47d3ff2823cae0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d50eeb3a966
Use constants defined in util/Unicode.h in CharacterEncoding.cpp r=arai

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8d50eeb3a966