1507504 - Crash in mozilla::nt::PEHeaders::FindResourceLeaf<T>

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-8264dd68-897f-4870-a1d1-2411b0181012.
=============================================================

Seen while looking at nightly crashes, seems to have started with 20181010235834 back when nightly was in 64: https://bit.ly/2FxyCY2. Seems to be a nightly only crash so far. Looks like a startup crash as well. 15 crashes/6 installs so far.

Some of the top level stacks point back to work that was done in Bug 1445025. ni on :aklotz for ideas since he worked on Bug 1445025

Top 10 frames of crashing thread:

0 firefox.exe static struct mozilla::nt::PEHeaders::VS_VERSIONINFO_HEADER* mozilla::nt::PEHeaders::FindResourceLeaf<mozilla::nt::PEHeaders::VS_VERSIONINFO_HEADER*> browser/app/winlauncher/NativeNt.h:397
1 firefox.exe bool mozilla::nt::PEHeaders::GetVersionInfo browser/app/winlauncher/NativeNt.h:337
2 firefox.exe static bool CheckBlockInfo browser/app/winlauncher/DllBlocklistWin.cpp:223
3 firefox.exe static long patched_NtMapViewOfSection browser/app/winlauncher/DllBlocklistWin.cpp:314
4 ntdll.dll LdrpMinimalMapModule 
5 ntdll.dll LdrpMapDllWithSectionHandle 
6 ntdll.dll LdrpMapDllNtFileName 
7 ntdll.dll LdrpMapDllFullPath 
8 ntdll.dll LdrpProcessWork 
9 ntdll.dll LdrpLoadDllInternal 

=============================================================

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

It looks like we're loading a PKCS11 module and something isn't right there. Unfortunately these dumps aren't every good and I can't really see which module is involved.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Moving to mozglue since this is blocklist related.

Comment 3

[Marcia Knous [:marcia]]

Adding 66 as affected. 10 crashes/5 installs in the last month.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Crashes all seem to be wildptr crashes -> sec bug

Comment 5

[Ryan VanderMeulen [:RyanVM]]

IIUC, this only affects the Windows process launcher, which isn't due to ride the trains until 67.

Comment 6

[Marcia Knous [:marcia]]

There are some crashes in the 3-5 Nightly 67 build. Adding 67 as affected.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

This was probably fixed by bug 1541597, which landed in 67 beta 9. We haven't seen any crashes since then, so I'm inclined to resolve this for now and reopen if it comes back.