Closed Bug 1507749 Opened 3 years ago Closed 3 years ago
Shape Path Editor throws error and stops working for inline style
47 bytes, text/x-phabricator-request
|Details | Review|
Steps to reproduce: - go to https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside - inspect the balloon image - toggle on the Shape Path Editor for the `shape-outside` property in the Rule view - attempt to drag the outer circle to resize the circle Result: The shape updates slightly, then stops working. Inspecting the browser console shows an error thrown: ``` Error: Invalid index -1. Expected positive integer: ```
The patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1467076 makes it that TextProperty instances created for the element's inline style are overwritten when the inline style is edited. The Shape Path Editor kept a reference to an old TextProperty.
Attachment #9025744 - Attachment description: Bug 1507749 - Account for changing TextProperty on when editing inline styles. r=pbro → Bug 1507749 - Account for changing TextProperty when editing inline styles. r=pbro
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4b78e1686da9 Account for changing TextProperty when editing inline styles. r=pbro
You need to log in before you can comment on or make changes to this bug.