1507749 - Shape Path Editor throws error and stops working for inline style

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Razvan Caliman [:rcaliman]]

Steps to reproduce:

- go to https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside
- inspect the balloon image
- toggle on the Shape Path Editor for the `shape-outside` property in the Rule view
- attempt to drag the outer circle to resize the circle

Result:
The shape updates slightly, then stops working. Inspecting the browser console shows an error thrown:

```
Error: Invalid index -1. Expected positive integer: 
```

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1507749 - Account for changing TextProperty when editing inline styles. r=pbro

The patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1467076 makes it that TextProperty instances created for the element's inline style are overwritten when the inline style is edited.
The Shape Path Editor kept a reference to an old TextProperty.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b78e1686da9
Account for changing TextProperty when editing inline styles. r=pbro

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4b78e1686da9

Comment 4

[Cristian Fogel [:cfogel]]

Confirmed the issue with 65.0a1 (20181116220054).
Fix verified with 65.0b12 on Windows 10, macOS10.11, Ubuntu 18.04.