Shape Path Editor throws error and stops working for inline style

VERIFIED FIXED in Firefox 65

Status

defect
P1
normal
VERIFIED FIXED
9 months ago
7 months ago

People

(Reporter: rcaliman, Assigned: rcaliman)

Tracking

(Blocks 1 bug)

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 verified)

Details

Attachments

(1 attachment)

Steps to reproduce:

- go to https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside
- inspect the balloon image
- toggle on the Shape Path Editor for the `shape-outside` property in the Rule view
- attempt to drag the outer circle to resize the circle

Result:
The shape updates slightly, then stops working. Inspecting the browser console shows an error thrown:

```
Error: Invalid index -1. Expected positive integer: 
```
The patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1467076 makes it that TextProperty instances created for the element's inline style are overwritten when the inline style is edited.
The Shape Path Editor kept a reference to an old TextProperty.
Attachment #9025744 - Attachment description: Bug 1507749 - Account for changing TextProperty on when editing inline styles. r=pbro → Bug 1507749 - Account for changing TextProperty when editing inline styles. r=pbro
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b78e1686da9
Account for changing TextProperty when editing inline styles. r=pbro
https://hg.mozilla.org/mozilla-central/rev/4b78e1686da9
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Flags: qe-verify+

Confirmed the issue with 65.0a1 (20181116220054).
Fix verified with 65.0b12 on Windows 10, macOS10.11, Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.