Remove ExcludeReadOnlyFolders option from places' queries

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: standard8, Assigned: jamesl33info, Mentored)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [lang=js|cpp])

Attachments

(1 attachment)

Reporter

Description

7 months ago
"ExcludeReadOnlyFolders" was used for excluding livemarks, since we didn't support any other form of read-only folders (and won't do).

When bug 1502954 lands, that will make it do nothing, so we should just remove it as well.
Reporter

Updated

7 months ago
Priority: -- → P2
Reporter

Comment 1

7 months ago
I'm happy to mentor anyone on this. There is a mixture of javascript and C++ work, and it will need a full Firefox build.

All references to "excludeReadOnlyFolders" should be removed, see this for a handy list:

https://searchfox.org/mozilla-central/search?q=ExcludeReadOnlyFolders&case=false&regexp=false&path=

Once you've removed the references, rebuild Firefox, and then run the main tests associated with this code:

```
$ ./mach xpcshell-test toolkit/components/places
$ ./mach mochitest browser/components/places
```

If all is well, there should be no issues.

Please submit a patch via phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Mentor: standard8
Whiteboard: [lang=js|cpp]

Comment 2

7 months ago
Hey Mark,

I would like to try this one. Although I'm not very familiar with the codebase, this one seems like an easy fix
Assignee

Comment 3

7 months ago
Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't 
(and will not) support read only folders.

Comment 4

7 months ago
(In reply to James Lee from comment #3)
> Created attachment 9027326 [details]
> Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries
> 
> Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't 
> (and will not) support read only folders.

Next time please write a comment on the bug before you start working on it
Assignee

Comment 5

7 months ago
(In reply to Ferenc Nagy from comment #4)
> (In reply to James Lee from comment #3)
> > Created attachment 9027326 [details]
> > Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries
> > 
> > Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't 
> > (and will not) support read only folders.
> 
> Next time please write a comment on the bug before you start working on it

Apologies if you had started any work on this; Mark explained to me in my last bug that I could just submit a patch without asking to be assigned. I may have taken that a little to literally. I will leave a comment before I start a bug next time.
Reporter

Comment 6

7 months ago
Yeah, sorry I'll change my text in future. It is generally a good idea to indicate if you're working on a bug, but you don't necessarily have to wait for the actual assignment.
Reporter

Updated

7 months ago
Assignee: nobody → jamesl33info

Comment 7

7 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/693821f7cf93
Remove 'ExcludeReadOnlyFolders' option from places' queries r=Standard8

Comment 8

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/693821f7cf93
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.