1508069 - Ignore js/src/editline in .clang-format-ignore

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Ted Campbell [:tcampbell]]

This is a 3rd-party import and shouldn't be reformatted with clang-format.

Q: Do we do the whole directory? What about the moz.build in it?

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Yeah, we do by directory and ignore moz.build files.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1508069 - Add js/src/editline to the ignore list r?andi

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b50a5b394b9
Add js/src/editline to the ignore list r=andi

Comment 4

[Ted Campbell [:tcampbell]]

f+, thanks.

Comment 5

[Ted Campbell [:tcampbell]]

That code is still in K+R style.. wow

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3b50a5b394b9

Comment 7

[(no longer active)]

Comment on attachment 9027278 [details]
Bug 1508069 - Add js/src/editline to the ignore list r?andi

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): NPOTB

String or UUID changes made by this patch: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9027278 [details]
Bug 1508069 - Add js/src/editline to the ignore list r?andi

OK for uplift to ESR60 as part of the clang-format project.

Comment 9

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/44e354f14da5