Closed Bug 1508069 Opened 5 years ago Closed 5 years ago

Ignore js/src/editline in .clang-format-ignore

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: tcampbell, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

Bug 1508069 - Add js/src/editline to the ignore list r?andi
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-esr60+
Details | Review 
This is a 3rd-party import and shouldn't be reformatted with clang-format.

Q: Do we do the whole directory? What about the moz.build in it?
Yeah, we do by directory and ignore moz.build files.
Assignee: nobody → sledru
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b50a5b394b9
Add js/src/editline to the ignore list r=andi
f+, thanks.
That code is still in K+R style.. wow
https://hg.mozilla.org/mozilla-central/rev/3b50a5b394b9
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9027278 [details]
Bug 1508069 - Add js/src/editline to the ignore list r?andi

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): NPOTB

String or UUID changes made by this patch: None
Attachment #9027278 - Flags: approval-mozilla-esr60?
Comment on attachment 9027278 [details]
Bug 1508069 - Add js/src/editline to the ignore list r?andi

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9027278 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.