1508062 - [meta] Cleanups in js/ for tree clang-format changes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

Tracking meta-bug for js/ issues related to upcoming clang-format policy enforcement in mozilla-central.

This is the sample of what changes will look at:
https://github.com/sylvestre/gecko-dev/commit/64bf50f46433de77b5e023b11f2390947a944b5e

Add blocking bugs for specific concerns or ignores that are justified.

Comment 1

[Tooru Fujisawa [:arai]]

According to the plan, we're going to apply the clang-format also to mozilla-esr60 branch,
that means most of the issues listed here will also happen there.

we'll need to backport them, to avoid the formatting issue, and also to make it easier to backport other critical changes.

Comment 2

[Ted Campbell [:tcampbell]]

An important thing I forgot to mention when exploring this stuff is that js/src/.clang-format exists in tree and running |mach clang-format| on js/src files will give slightly strange results. Bug 1508128 will fix this but in the mean time, you should apply the patch there locally when experimenting with clang-format results.

Comment 3

[Jan de Mooij [:jandem]]

Reformatted js/src and js/public (with some in-flight fixes):

https://hg.mozilla.org/try/rev/e3c9cfad69c33edddf800201b1c4547cf82eaf8c

To browse js/src files: https://hg.mozilla.org/try/file/e3c9cfad69c33edddf800201b1c4547cf82eaf8c/js/src/

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Ted, can we close this bug?
Thanks

Comment 5

[Ted Campbell [:tcampbell]]

Yeah, let's close this. I think it was a success. The remaining open bugs are low priority nice-to-haves.