[meta] Cleanups in js/ for tree clang-format changes

RESOLVED FIXED

Status

()

task
P1
normal
RESOLVED FIXED
7 months ago
3 months ago

People

(Reporter: tcampbell, Unassigned)

Tracking

(Depends on 1 bug, Blocks 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

7 months ago
Tracking meta-bug for js/ issues related to upcoming clang-format policy enforcement in mozilla-central.

This is the sample of what changes will look at:
https://github.com/sylvestre/gecko-dev/commit/64bf50f46433de77b5e023b11f2390947a944b5e

Add blocking bugs for specific concerns or ignores that are justified.
Reporter

Updated

7 months ago
Depends on: 1508063
Reporter

Updated

7 months ago
Depends on: 1508064
Reporter

Updated

7 months ago
Depends on: 1508065
Reporter

Updated

7 months ago
Depends on: 1508067
Reporter

Updated

7 months ago
Depends on: 1508069
Reporter

Updated

7 months ago
Depends on: 1508095
Reporter

Updated

7 months ago
Depends on: 1508097
Reporter

Updated

7 months ago
Depends on: 1508098
Reporter

Updated

7 months ago
Depends on: 1508106
Reporter

Updated

7 months ago
Depends on: 1508160
Reporter

Updated

7 months ago
Depends on: 1508176
Depends on: 1508178
According to the plan, we're going to apply the clang-format also to mozilla-esr60 branch,
that means most of the issues listed here will also happen there.

we'll need to backport them, to avoid the formatting issue, and also to make it easier to backport other critical changes.
Reporter

Comment 2

7 months ago
An important thing I forgot to mention when exploring this stuff is that js/src/.clang-format exists in tree and running |mach clang-format| on js/src files will give slightly strange results. Bug 1508128 will fix this but in the mean time, you should apply the patch there locally when experimenting with clang-format results.
Reporter

Updated

7 months ago
Depends on: 1508255
Reporter

Updated

7 months ago
Depends on: 1508180
Depends on: 1509010
Depends on: 1509025
Summary: Cleanups in js/ for tree clang-format changes → [meta] Cleanups in js/ for tree clang-format changes
Reporter

Updated

7 months ago
Depends on: 1510128
Depends on: 1510535
Depends on: 1499323
Depends on: 1510682
Depends on: 1513555
Type: defect → task

Ted, can we close this bug?
Thanks

Flags: needinfo?(tcampbell)
Reporter

Comment 5

3 months ago

Yeah, let's close this. I think it was a success. The remaining open bugs are low priority nice-to-haves.

Status: NEW → RESOLVED
Closed: 3 months ago
Flags: needinfo?(tcampbell)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.