1508168 - mach bootstrap for Firefox Android does not install required dependency nasm

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Chris Peterson [:cpeterson]]

mach bootstrap for Firefox Desktop *does* install nasm. I am running macOS 10.14.1.

After running mach bootstrap for a non-artifact build of Firefox for Android, mach configure fails with the following error:

DEBUG: | nasm: error: unable to find utility "nasm", not a developer tool or in PATH

If I run mach bootstrap for a non-artifact build of Firefox for Desktop, mach bootstrap installs nasm:

==> Downloading https://homebrew.bintray.com/bottles/nasm-2.14.mojave.bottle.tar.gz
Already downloaded: /Users/chris/Library/Caches/Homebrew/downloads/797a1b9ef416d0a35cd7071c8488b8e4edacc3f36268b7a8c6bfd38c9acc3cb1--nasm-2.14.mojave.bottle.tar.gz
==> Pouring nasm-2.14.mojave.bottle.tar.gz
🍺  /usr/local/Cellar/nasm/2.14: 30 files, 2.7MB

Comment 1

[Axel Nennker]

I run mach bootstrap for a non-artifact build of Firefox for Desktop
Bootstrap is looking for /usr/bin/nasm although it is installed in /usr/local/bin/nasm on my machine.

I compiled and installed nasm from git because the version on Ubuntu 16.04 is too old to work on ipred.asm

Bootstrap should look for nasm in the path and not depend on /usr/bin/nasm
Bootstrap should check for the version of nasm that works with ipred.asm
(Maybe './mach build' should clobber if nasm changed)

Comment 3

[Nathan Froyd [:froydnj]]

Bug 1521186 only covered Windows and Linux. This bug is for Android builds.

Comment 4

[Thomas Daede [:TD-Linux]]

moz.configure no longer checks for nasm on Android.