1508364 - New UI for Private Browsing with Search

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ursula Sarracini (:ursula)]

Spec: https://mozilla.invisionapp.com/share/RCOSEBEGW8Q#/screens

We need to update the private browsing page to have the search box, and then box underneath which has a description and an external link

Comment 1

[Aaron Benson]

Temporary link for the "Common Myths" article shown in the design spec: https://support.mozilla.org/1/firefox/%25VERSION%25/%25OS%25/%25LOCALE%25/private-browsing-myths

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1508364 - New UI for Private Browsing with Search

MozReview-Commit-ID: 4WSGpL5Gvde

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13f379946829
New UI for Private Browsing with Search r=andreio

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

QA Notes:

The implementation is slightly different from what is on Activity Stream/Newtab page until we port the changes over:

• It is hidden from keyboard navigation (tabindex=-1)
• It prepends the search alias (@google, for example) on hand-off

The following should be tested for the search hand-off:

• click and type
• click and type with Japanese IME and other language keyboards
• click and cmd/ctrl + v to paste
• right click and paste from context menu
• try with different default search engines
• try with a custom default search engine (Youtube, for example)

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out changeset 13f379946829 (bug 1508364) for functional ui test failures on private_browsing/test_about_private_browsing.py CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/32541f2f057571ac075a6893689e30e676ac7d23

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=223135215&revision=13f379946829814f44e8e7b192ac4dd4e93d6959

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=223139740&repo=autoland

:rrosario could you please take a look?

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Arthur Iakab [arthur_iakab] from comment #5)

:rrosario could you please take a look?

Gah, my bad. I missed adding marionette to my try build. Fixing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3de18f0e694
New UI for Private Browsing with Search r=andreio

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a3de18f0e694

Comment 9

[Pascal Chevrel:pascalc]

That seems like something we should have a release note for, at least on Nightly, Ricky can you request one please? https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F

I am also not seeing a Trello card about it for 66 and this new private browsing window with search doesn't seem to be behind a nightly only flag, is it riding the trains to 66?

Thanks

(Ccing liz as she is the release manager for 66)

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Release Note Request (optional, but appreciated)
[Why is this notable]: It's a new about:privatebrowsing UI that all users will see when in private browsing mode
[Affects Firefox for Android]: No
[Suggested wording]: New about:privatebrowsing with search
[Links (documentation, blog post, etc)]:
^ All I have is the spec in Comment 0. I'll check if there is anything else yet.

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Pascal Chevrel:pascalc from comment #9)

That seems like something we should have a release note for, at least on Nightly, Ricky can you request one please? https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F

Done. Thank you!

I am also not seeing a Trello card about it for 66 and this new private browsing window with search doesn't seem to be behind a nightly only flag, is it riding the trains to 66?

Yes, it will ride the trains.

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

Actually, it will be pref'd off by default in Release 66. See Bug 1521961. So I guess it doesn't go into the release notes?

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like it is in Trello now and there's a PI request filed.
https://trello.com/c/m7Mzv7wy/643-search-in-private-browsing-mode

Comment 14

[Pascal Chevrel:pascalc]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #12)

Actually, it will be pref'd off by default in Release 66. See Bug 1521961. So I guess it doesn't go into the release notes?

It's in Nightly so we need it for our Nightly release notes.

Comment 15

[Pascal Chevrel:pascalc]

I went with this wording for the Nightly release note:
The home page in a Private Browsing windows now includes a search field which uses your default search engine

Comment 16

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Pascal Chevrel:pascalc from comment #15)

I went with this wording for the Nightly release note:
The home page in a Private Browsing windows now includes a search field which uses your default search engine

Awesome, much better :). Thank you!

Comment 17

[Sajedul Islam]

I have reproduced this bug with Nightly 65.0a1 (2018-11-19) on Windows 10, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID : 20190128092811
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Comment 18

[Grey Nicholson (they/them)]

Wait, what's the rationale for doing this?

This is really confusing — the location bar is already focused by default when you open a private window. Why do we need a 2nd one visible at the same time? Which one are you supposed to use? It seems like we're just making users falsely believe they have to do an extra click before they can search.

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Noted as "Easier search via a redesigned new tab in Private Windows."