1508468 - Make launcher process use mozilla::Result

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This gives us a way to properly propagate errors up to the top of the launcher process' call stack, at which point we can call into a handler to do something appropriate.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1508468: Convert launcher process to use mozilla::Result for error propagation; r=mhowell!

This patch does a couple of things:

* I added a new class, |WindowsError| to WinHeaderOnlyUtils. The idea here is
  to encapsulate as much of the Windows error gamut as possible into one class.
  Since Win32 errors and NTSTATUS codes may both be encoded as HRESULTs, I
  used the latter type to store the error. It also contains functions for
  converting between the various error code formats, as well as stringification
  via FormatMessage.

* I added |LauncherError| which also includes file and line number information,
  which I believe will be important for launcher process failure diagnostics.
  (Instantiation of LauncherErrors obviously must be done via macros to capture
  __FILE__ and __LINE__).

* I then converted all of the launcher process code (and its few depenencies) to
  utilize this new functionality via the new |LauncherResult| type.

* If we detect an error in one of the top-level launcher process functions, we
  pass it to |HandleLauncherError| for processing. This function currently just
  throws up a |MessageBox| like the previous code did, with the intention of
  enhancing that further in the future.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5660a1cd0e25
Convert launcher process to use mozilla::Result for error propagation; r=mhowell

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for Windows MinGW bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/453589993f45bd5ac46350916fb843de25745aa7
Push link: https://hg.mozilla.org/integration/autoland/rev/5660a1cd0e25d0a179cc6ed1dbac9158994d3990
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=212964215&repo=autoland&lineNumber=39476

Comment 4

[Narcis Beleuzu [:NarcisB]]

There were also bustages on ntstatus.h

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=212964217&repo=autoland&lineNumber=34995

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ff2e89a1819
Convert launcher process to use mozilla::Result for error propagation; r=mhowell

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out for: Backed out changeset 0ff2e89a1819 (Bug 1508468) for windows build bustages on ntstatus.h.

Backout: https://hg.mozilla.org/integration/autoland/rev/7a3593c06bf77e7054d153180360f19a24c3f00b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=0ff2e89a18191e32118e7c0aed5b554cf1a00ec6&selectedJob=212985893

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212985893&repo=autoland&lineNumber=34247

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be8383028bc0
Convert launcher process to use mozilla::Result for error propagation; r=mhowell

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1508468: Follow-up: fix incorrect negation; r=mhowell!

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for windows build bustage

Backout link: https://hg.mozilla.org/integration/autoland/rev/f5dfe72df46786a1683699c3d78208a28d739527
Push link: https://hg.mozilla.org/integration/autoland/rev/be8383028bc02b2ab24a8102d0b1276f15af4764
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=213001991&repo=autoland&lineNumber=34413

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa0d05453365
Convert launcher process to use mozilla::Result for error propagation; r=mhowell

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fa0d05453365