Closed Bug 1508848 Opened 9 months ago Closed 9 months ago

Fix semantics of WindowsError

Categories

(Core :: Widget: Win32, enhancement)

Unspecified
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file)

operator bool isn't cutting it, because it isn't clear what that means.

Does !error mean that there isn't an error or not? We're better off being explicit here.
Depends on: 1508468
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b1b35582dd7
Remove operator bool from WindowsError and replace with IsSuccess and IsFailure methods; r=mhowell
https://hg.mozilla.org/mozilla-central/rev/8b1b35582dd7
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.