Migrate nodepicker utils out of highlighterutils

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: yulia, Assigned: yulia)

Tracking

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(6 attachments, 1 obsolete attachment)

As part of removing highlighter utils, we should move the picker methods elsewhere

We have some shared functionality with the walker and selection modules. The best way to share these is via an intermediary module, as otherwise we would need to call get parent(), which is expensive
Attachment #9026393 - Attachment is obsolete: true
Attachment #9031241 - Attachment description: Bug 1504185 - migrate picker-node-hovered to nodePicker; r=ochameau → Bug 1508656 - migrate picker-node-hovered to nodePicker; r=ochameau
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70db61618160
migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/eb4c893d451e
migrate startPicker and stopPicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/8b01632f9e3d
migrate togglePicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/f1905a2f9b6c
migrate cancel picker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/8b98b777aec2
migrate picker-node-hovered to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/caafdc0ea4c7
fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau
The fix is on bug 1508660, had to do with rebase conflicts.
Flags: needinfo?(ystartsev)
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1ec7884d2cc
migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/cb8e0fb71422
migrate startPicker and stopPicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/a20625c5026f
migrate togglePicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/d78f0458b4d9
migrate cancel picker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/fbf96ce2270b
migrate picker-node-hovered to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/c96ac5e87209
fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau
You need to log in before you can comment on or make changes to this bug.