1508656 - Migrate nodepicker utils out of highlighterutils

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Yulia Startsev [:yulia]]

As part of removing highlighter utils, we should move the picker methods elsewhere

We have some shared functionality with the walker and selection modules. The best way to share these is via an intermediary module, as otherwise we would need to call get parent(), which is expensive

Comment 1

[Yulia Startsev [:yulia]]

Attachment: bug 1508656 - migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1508656- migrate togglePicker to nodePicker; r=ochameau

Depends on D12119

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1508656 - migrate startPicker and stopPicker to nodePicker; r=ochameau

Depends on D12122

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1508656 - migrate cancel picker to nodePicker; r=ochameau

Depends on D12126

Comment 5

[Yulia Startsev [:yulia]]

Attachment: Bug 1508656 - fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau

Depends on D12290

Comment 6

[Yulia Startsev [:yulia]]

Attachment: Bug 1508656 - BoxModel highlighter - move nodeHighlighter to highlighterFront; r=ochameau

Depends on D12319

Comment 7

[Yulia Startsev [:yulia]]

Attachment: Bug 1508656 - migrate picker-node-hovered to nodePicker; r=ochameau

Depends on D12290

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70db61618160
migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/eb4c893d451e
migrate startPicker and stopPicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/8b01632f9e3d
migrate togglePicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/f1905a2f9b6c
migrate cancel picker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/8b98b777aec2
migrate picker-node-hovered to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/caafdc0ea4c7
fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau

Comment 9

[Andrei Ciure[:aciure]]

Backed out 14 changesets (bug 1508660, bug 1508656, bug 1504185) for browser_target_cached-front.js perma failures

push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=01b687bb0b757a895c971f884da00f79130afc4a

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=c00b8c0f29ba7c9cace06d85283f66d070f2eb3e&selectedJob=217440230&searchStr=linux%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32%2Fopt-mochitest-devtools-chrome-e10s-7%2Cm-e10s%28dt7%29

backout: https://hg.mozilla.org/integration/autoland/rev/fbe9f6e140aee8dc0d152c16c8f9171683b5140a

Comment 10

[Yulia Startsev [:yulia]]

The fix is on bug 1508660, had to do with rebase conflicts.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1ec7884d2cc
migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/cb8e0fb71422
migrate startPicker and stopPicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/a20625c5026f
migrate togglePicker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/d78f0458b4d9
migrate cancel picker to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/fbf96ce2270b
migrate picker-node-hovered to nodePicker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/c96ac5e87209
fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c1ec7884d2cc
https://hg.mozilla.org/mozilla-central/rev/cb8e0fb71422
https://hg.mozilla.org/mozilla-central/rev/a20625c5026f
https://hg.mozilla.org/mozilla-central/rev/d78f0458b4d9
https://hg.mozilla.org/mozilla-central/rev/fbf96ce2270b
https://hg.mozilla.org/mozilla-central/rev/c96ac5e87209