Closed Bug 1504185 Opened 2 years ago Closed 2 years ago

remove highlighterUtils module

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: ystartsev, Assigned: ystartsev)

References

Details

(Whiteboard: dt-fission)

Attachments

(2 files, 27 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
The highlighterUtils module is no longer necessary, as the inspector can be instantiated asynchronously, and the inspector front now contains a map of highlighters, as well as cached references to the walker, boxHighlighter, and selection. 

highlighterUtils: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/framework/toolbox-highlighter-utils.js#30

inspectorFront: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/shared/fronts/inspector.js

call locations: https://searchfox.org/mozilla-central/search?q=highlighterUtils&case=false&regexp=false&path=
Depends on D11065
Depends on D11067
Depends on D11068
Depends on D11069
Depends on D11070
Depends on D11071
Depends on D11073
Depends on D11074
Depends on D11075
Depends on D11076
Depends on D11078
Depends on D11081
Depends on D11082
Attachment #9025665 - Attachment is obsolete: true
Attachment #9025665 - Attachment is obsolete: false
Depends on D12119
Depends on D12122
Depends on D12126
Attachment #9023001 - Attachment is obsolete: true
Attachment #9023004 - Attachment is obsolete: true
Attachment #9022999 - Attachment is obsolete: true
Attachment #9023005 - Attachment is obsolete: true
Attachment #9023006 - Attachment is obsolete: true
Attachment #9023007 - Attachment is obsolete: true
Attachment #9023009 - Attachment is obsolete: true
Attachment #9023010 - Attachment is obsolete: true
Attachment #9023011 - Attachment is obsolete: true
Attachment #9023012 - Attachment is obsolete: true
Attachment #9023013 - Attachment is obsolete: true
Attachment #9023014 - Attachment is obsolete: true
Attachment #9023015 - Attachment is obsolete: true
Attachment #9023016 - Attachment is obsolete: true
Attachment #9023017 - Attachment is obsolete: true
Attachment #9023018 - Attachment is obsolete: true
Attachment #9023019 - Attachment is obsolete: true
Attachment #9023020 - Attachment is obsolete: true
Attachment #9023021 - Attachment is obsolete: true
Depends on: 1508655
Depends on: 1508656
Attachment #9026143 - Attachment is obsolete: true
Attachment #9026145 - Attachment is obsolete: true
Attachment #9025665 - Attachment is obsolete: true
Attachment #9026038 - Attachment is obsolete: true
Attachment #9026039 - Attachment is obsolete: true
Attachment #9026083 - Attachment is obsolete: true
Attachment #9026084 - Attachment is obsolete: true
Depends on: 1508660
Depends on D12290
Attachment #9027132 - Attachment is obsolete: true
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/140374b098aa
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/01b687bb0b75
remove highlighterUtils documentation from devtools; r=ochameau
The fix is on bug 1508660, had to do with rebase conflicts.
Flags: needinfo?(ystartsev)
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ae23429e483
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/687cf3017ca7
remove highlighterUtils documentation from devtools; r=ochameau
https://hg.mozilla.org/mozilla-central/rev/2ae23429e483
https://hg.mozilla.org/mozilla-central/rev/687cf3017ca7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.