remove highlighterUtils module

RESOLVED FIXED in Firefox 66

Status

P2
enhancement
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: yulia, Assigned: yulia)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(2 attachments, 27 obsolete attachments)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
(Assignee)

Description

4 months ago
The highlighterUtils module is no longer necessary, as the inspector can be instantiated asynchronously, and the inspector front now contains a map of highlighters, as well as cached references to the walker, boxHighlighter, and selection. 

highlighterUtils: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/framework/toolbox-highlighter-utils.js#30

inspectorFront: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/shared/fronts/inspector.js

call locations: https://searchfox.org/mozilla-central/search?q=highlighterUtils&case=false&regexp=false&path=
(Assignee)

Comment 1

4 months ago
Created attachment 9022999 [details]
Bug 1504185 - stop using highlighterUtils in the accessibility panel; r=ochameau
(Assignee)

Comment 2

4 months ago
Created attachment 9023001 [details]
bug 1504185 - migrate togglePicker from highlighterUtils to the fronts; r=ochameau
(Assignee)

Comment 3

4 months ago
Created attachment 9023004 [details]
bug 1504185 - migrate boxmodel methods to highlighterFront; r=ochameau

Depends on D11065
(Assignee)

Comment 4

4 months ago
Created attachment 9023005 [details]
bug 1504185 - stop using highlighterUtils in the toolbox; r=ochameau

Depends on D11067
(Assignee)

Comment 5

4 months ago
Created attachment 9023006 [details]
bug 1504185 - stop using highlighter utils in definitions; r=ochameau

Depends on D11068
(Assignee)

Comment 6

4 months ago
Created attachment 9023007 [details]
bug 1504185 - stop using highlighterUtils for ToolboxToolbar; r=ochameau

Depends on D11069
(Assignee)

Comment 7

4 months ago
Created attachment 9023009 [details]
bug 1504185 - stop using highlighterUtils in the animation panel; r=ochameau

Depends on D11070
(Assignee)

Comment 8

4 months ago
Created attachment 9023010 [details]
bug 1504185 - stop using highlighterUtils in the boxmodel panel; r=ochameau

Depends on D11071
(Assignee)

Comment 9

4 months ago
Created attachment 9023011 [details]
bug 1504185 - stop using highlighterUtils in the breadcrumbs component; r=ochameau

Depends on D11072
(Assignee)

Comment 10

4 months ago
Created attachment 9023012 [details]
bug 1504185 - stop using highlighterUtils in the fonts component; r=ochameau

Depends on D11073
(Assignee)

Comment 11

4 months ago
Created attachment 9023013 [details]
bug 1504185 - stop using highlighterUtils in the inspector; r=ochameau

Depends on D11074
(Assignee)

Comment 12

4 months ago
Created attachment 9023014 [details]
bug 1504185 - stop using highlighterUtils in the markup; r=ochameau

Depends on D11075
(Assignee)

Comment 13

4 months ago
Created attachment 9023015 [details]
bug 1504185 - stop using highlighterUtils in the rules component; r=ochameau

Depends on D11076
(Assignee)

Comment 14

4 months ago
Created attachment 9023016 [details]
bug 1504185 - stop using highlighterUtils in the highlighter overlay; r=ochameau

Depends on D11077
(Assignee)

Comment 15

4 months ago
Created attachment 9023017 [details]
bug 1504185 - stop using highlighterUtils in the variable view; r=ochameau

Depends on D11078
(Assignee)

Comment 16

4 months ago
Created attachment 9023018 [details]
bug 1504185 - stop using highlighterUtils in the colorpicker tooltip; r=ochameau

Depends on D11079
(Assignee)

Comment 17

4 months ago
Created attachment 9023019 [details]
bug 1504185 - stop using highlighterUtils in the webconsoleOutputWrapper; r=ochameau

Depends on D11080
(Assignee)

Comment 18

4 months ago
Created attachment 9023020 [details]
bug 1504185 - stop using highlighterUtils in the extensionSidebar; r=ochameau

Depends on D11081
(Assignee)

Comment 19

4 months ago
Created attachment 9023021 [details]
bug 1504185 - stop using highlighterUtils from tests; r=ochameau

Depends on D11082
(Assignee)

Comment 20

4 months ago
Created attachment 9023022 [details]
bug 1504185 - remove highlighterUtils from devtools; r=ochameau

Depends on D11083
(Assignee)

Comment 21

4 months ago
Created attachment 9023023 [details]
bug 1504185 - remove highlighterUtils documentation from devtools; r=ochameau

Depends on D11084
(Assignee)

Comment 23

3 months ago
Created attachment 9025665 [details]
bug 1504185 - migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau
Attachment #9025665 - Attachment is obsolete: true
Attachment #9025665 - Attachment is obsolete: false
(Assignee)

Comment 24

3 months ago
Created attachment 9026038 [details]
Bug 1504185- migrate togglePicker to nodePicker; r=ochameau

Depends on D12119
(Assignee)

Comment 25

3 months ago
Created attachment 9026039 [details]
Bug 1504185 - migrate startPicker and stopPicker to nodePicker; r=ochameau

Depends on D12122
(Assignee)

Comment 26

3 months ago
Created attachment 9026083 [details]
Bug 1504185 - migrate cancel picker to nodePicker; r=ochameau

Depends on D12126
(Assignee)

Comment 27

3 months ago
Created attachment 9026084 [details]
Bug 1504185 - fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau

Depends on D12290
(Assignee)

Comment 28

3 months ago
Created attachment 9026143 [details]
Bug 1504185 - BoxModel highlighter - split domGrip methods to make them more closely related to the walker; r=ochameau
(Assignee)

Comment 29

3 months ago
Created attachment 9026145 [details]
Bug 1504185 - BoxModel highlighter - move nodeHighlighter to highlighterFront; r=ochameau

Depends on D12319
Attachment #9023001 - Attachment is obsolete: true
Attachment #9023004 - Attachment is obsolete: true
Attachment #9022999 - Attachment is obsolete: true
Attachment #9023005 - Attachment is obsolete: true
Attachment #9023006 - Attachment is obsolete: true
Attachment #9023007 - Attachment is obsolete: true
Attachment #9023009 - Attachment is obsolete: true
Attachment #9023010 - Attachment is obsolete: true
Attachment #9023011 - Attachment is obsolete: true
Attachment #9023012 - Attachment is obsolete: true
Attachment #9023013 - Attachment is obsolete: true
Attachment #9023014 - Attachment is obsolete: true
Attachment #9023015 - Attachment is obsolete: true
Attachment #9023016 - Attachment is obsolete: true
Attachment #9023017 - Attachment is obsolete: true
Attachment #9023018 - Attachment is obsolete: true
Attachment #9023019 - Attachment is obsolete: true
Attachment #9023020 - Attachment is obsolete: true
Attachment #9023021 - Attachment is obsolete: true
(Assignee)

Updated

3 months ago
Depends on: 1508655
(Assignee)

Updated

3 months ago
Depends on: 1508656
Attachment #9026143 - Attachment is obsolete: true
Attachment #9026145 - Attachment is obsolete: true
Attachment #9025665 - Attachment is obsolete: true
Attachment #9026038 - Attachment is obsolete: true
Attachment #9026039 - Attachment is obsolete: true
Attachment #9026083 - Attachment is obsolete: true
Attachment #9026084 - Attachment is obsolete: true
(Assignee)

Updated

3 months ago
Depends on: 1508660
(Assignee)

Comment 30

3 months ago
Created attachment 9027132 [details]
Bug 1504185 - migrate picker-node-hovered to nodePicker; r=ochameau

Depends on D12290
Attachment #9027132 - Attachment is obsolete: true

Comment 31

2 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/140374b098aa
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/01b687bb0b75
remove highlighterUtils documentation from devtools; r=ochameau
(Assignee)

Comment 33

2 months ago
The fix is on bug 1508660, had to do with rebase conflicts.
Flags: needinfo?(ystartsev)

Comment 34

2 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ae23429e483
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/687cf3017ca7
remove highlighterUtils documentation from devtools; r=ochameau

Comment 35

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ae23429e483
https://hg.mozilla.org/mozilla-central/rev/687cf3017ca7
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.