Closed
Bug 1504185
Opened 4 years ago
Closed 4 years ago
remove highlighterUtils module
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
Details
(Whiteboard: dt-fission)
Attachments
(2 files, 27 obsolete files)
The highlighterUtils module is no longer necessary, as the inspector can be instantiated asynchronously, and the inspector front now contains a map of highlighters, as well as cached references to the walker, boxHighlighter, and selection. highlighterUtils: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/framework/toolbox-highlighter-utils.js#30 inspectorFront: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/shared/fronts/inspector.js call locations: https://searchfox.org/mozilla-central/search?q=highlighterUtils&case=false®exp=false&path=
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D11065
Assignee | ||
Comment 4•4 years ago
|
||
Depends on D11067
Assignee | ||
Comment 5•4 years ago
|
||
Depends on D11068
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D11069
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D11070
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D11071
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D11072
Assignee | ||
Comment 10•4 years ago
|
||
Depends on D11073
Assignee | ||
Comment 11•4 years ago
|
||
Depends on D11074
Assignee | ||
Comment 12•4 years ago
|
||
Depends on D11075
Assignee | ||
Comment 13•4 years ago
|
||
Depends on D11076
Assignee | ||
Comment 14•4 years ago
|
||
Depends on D11077
Assignee | ||
Comment 15•4 years ago
|
||
Depends on D11078
Assignee | ||
Comment 16•4 years ago
|
||
Depends on D11079
Assignee | ||
Comment 17•4 years ago
|
||
Depends on D11080
Assignee | ||
Comment 18•4 years ago
|
||
Depends on D11081
Assignee | ||
Comment 19•4 years ago
|
||
Depends on D11082
Assignee | ||
Comment 20•4 years ago
|
||
Depends on D11083
Assignee | ||
Comment 21•4 years ago
|
||
Depends on D11084
Assignee | ||
Comment 22•4 years ago
|
||
try run for "stop using ...": https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ab88c6c05590f547bc2d43afc3fa0f14db8d2d8 try run for removing component: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48b655194fad11178a92f1fb17d9e52b9048ecb2
Assignee | ||
Comment 23•4 years ago
|
||
Updated•4 years ago
|
Attachment #9025665 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9025665 -
Attachment is obsolete: false
Assignee | ||
Comment 24•4 years ago
|
||
Depends on D12119
Assignee | ||
Comment 25•4 years ago
|
||
Depends on D12122
Assignee | ||
Comment 26•4 years ago
|
||
Depends on D12126
Assignee | ||
Comment 27•4 years ago
|
||
Depends on D12290
Assignee | ||
Comment 28•4 years ago
|
||
Assignee | ||
Comment 29•4 years ago
|
||
Depends on D12319
Updated•4 years ago
|
Attachment #9023001 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023004 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9022999 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023005 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023006 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023007 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023009 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023010 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023011 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023012 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023013 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023014 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023015 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023016 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023017 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023018 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023019 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023020 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9023021 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9026143 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9026145 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9025665 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9026038 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9026039 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9026083 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9026084 -
Attachment is obsolete: true
Assignee | ||
Comment 30•4 years ago
|
||
Depends on D12290
Updated•4 years ago
|
Attachment #9027132 -
Attachment is obsolete: true
Comment 31•4 years ago
|
||
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/140374b098aa remove highlighterUtils from devtools; r=ochameau https://hg.mozilla.org/integration/autoland/rev/01b687bb0b75 remove highlighterUtils documentation from devtools; r=ochameau
Comment 32•4 years ago
|
||
Backed out 14 changesets (bug 1508660, bug 1508656, bug 1504185) for browser_target_cached-front.js perma failures push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=01b687bb0b757a895c971f884da00f79130afc4a failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=c00b8c0f29ba7c9cace06d85283f66d070f2eb3e&selectedJob=217440230&searchStr=linux%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32%2Fopt-mochitest-devtools-chrome-e10s-7%2Cm-e10s%28dt7%29 backout: https://hg.mozilla.org/integration/autoland/rev/fbe9f6e140aee8dc0d152c16c8f9171683b5140a
Flags: needinfo?(ystartsev)
Assignee | ||
Comment 33•4 years ago
|
||
The fix is on bug 1508660, had to do with rebase conflicts.
Flags: needinfo?(ystartsev)
Comment 34•4 years ago
|
||
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ae23429e483 remove highlighterUtils from devtools; r=ochameau https://hg.mozilla.org/integration/autoland/rev/687cf3017ca7 remove highlighterUtils documentation from devtools; r=ochameau
Comment 35•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ae23429e483 https://hg.mozilla.org/mozilla-central/rev/687cf3017ca7
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•