1504185 - remove highlighterUtils module

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Yulia Startsev]

The highlighterUtils module is no longer necessary, as the inspector can be instantiated asynchronously, and the inspector front now contains a map of highlighters, as well as cached references to the walker, boxHighlighter, and selection. 

highlighterUtils: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/framework/toolbox-highlighter-utils.js#30

inspectorFront: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/shared/fronts/inspector.js

call locations: https://searchfox.org/mozilla-central/search?q=highlighterUtils&case=false&regexp=false&path=

Comment 1

[Yulia Startsev]

Attachment: Bug 1504185 - stop using highlighterUtils in the accessibility panel; r=ochameau

Comment 2

[Yulia Startsev]

Attachment: bug 1504185 - migrate togglePicker from highlighterUtils to the fronts; r=ochameau

Comment 3

[Yulia Startsev]

Attachment: bug 1504185 - migrate boxmodel methods to highlighterFront; r=ochameau

Depends on D11065

Comment 4

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the toolbox; r=ochameau

Depends on D11067

Comment 5

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighter utils in definitions; r=ochameau

Depends on D11068

Comment 6

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils for ToolboxToolbar; r=ochameau

Depends on D11069

Comment 7

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the animation panel; r=ochameau

Depends on D11070

Comment 8

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the boxmodel panel; r=ochameau

Depends on D11071

Comment 9

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the breadcrumbs component; r=ochameau

Depends on D11072

Comment 10

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the fonts component; r=ochameau

Depends on D11073

Comment 11

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the inspector; r=ochameau

Depends on D11074

Comment 12

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the markup; r=ochameau

Depends on D11075

Comment 13

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the rules component; r=ochameau

Depends on D11076

Comment 14

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the highlighter overlay; r=ochameau

Depends on D11077

Comment 15

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the variable view; r=ochameau

Depends on D11078

Comment 16

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the colorpicker tooltip; r=ochameau

Depends on D11079

Comment 17

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the webconsoleOutputWrapper; r=ochameau

Depends on D11080

Comment 18

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils in the extensionSidebar; r=ochameau

Depends on D11081

Comment 19

[Yulia Startsev]

Attachment: bug 1504185 - stop using highlighterUtils from tests; r=ochameau

Depends on D11082

Comment 20

[Yulia Startsev]

Attachment: bug 1504185 - remove highlighterUtils from devtools; r=ochameau

Depends on D11083

Comment 21

[Yulia Startsev]

Attachment: bug 1504185 - remove highlighterUtils documentation from devtools; r=ochameau

Depends on D11084

Comment 22

[Yulia Startsev]

try run for "stop using ...": https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ab88c6c05590f547bc2d43afc3fa0f14db8d2d8
try run for removing component: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48b655194fad11178a92f1fb17d9e52b9048ecb2

Comment 23

[Yulia Startsev]

Attachment: bug 1504185 - migrate node picking methods to NodePicker module, and use it through the inspector; r=ochameau

Comment 24

[Yulia Startsev]

Attachment: Bug 1504185- migrate togglePicker to nodePicker; r=ochameau

Depends on D12119

Comment 25

[Yulia Startsev]

Attachment: Bug 1504185 - migrate startPicker and stopPicker to nodePicker; r=ochameau

Depends on D12122

Comment 26

[Yulia Startsev]

Attachment: Bug 1504185 - migrate cancel picker to nodePicker; r=ochameau

Depends on D12126

Comment 27

[Yulia Startsev]

Attachment: Bug 1504185 - fix failing test browser_inspector_switch-to-inspector-on-pick; r=ochameau

Depends on D12290

Comment 28

[Yulia Startsev]

Attachment: Bug 1504185 - BoxModel highlighter - split domGrip methods to make them more closely related to the walker; r=ochameau

Comment 29

[Yulia Startsev]

Attachment: Bug 1504185 - BoxModel highlighter - move nodeHighlighter to highlighterFront; r=ochameau

Depends on D12319

Comment 30

[Yulia Startsev]

Attachment: Bug 1504185 - migrate picker-node-hovered to nodePicker; r=ochameau

Depends on D12290

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/140374b098aa
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/01b687bb0b75
remove highlighterUtils documentation from devtools; r=ochameau

Comment 32

[Andrei Ciure[:aciure]]

Backed out 14 changesets (bug 1508660, bug 1508656, bug 1504185) for browser_target_cached-front.js perma failures

push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=01b687bb0b757a895c971f884da00f79130afc4a

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=c00b8c0f29ba7c9cace06d85283f66d070f2eb3e&selectedJob=217440230&searchStr=linux%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32%2Fopt-mochitest-devtools-chrome-e10s-7%2Cm-e10s%28dt7%29

backout: https://hg.mozilla.org/integration/autoland/rev/fbe9f6e140aee8dc0d152c16c8f9171683b5140a

Comment 33

[Yulia Startsev]

The fix is on bug 1508660, had to do with rebase conflicts.

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae23429e483
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/687cf3017ca7
remove highlighterUtils documentation from devtools; r=ochameau

Comment 35

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2ae23429e483
https://hg.mozilla.org/mozilla-central/rev/687cf3017ca7