remove highlighterUtils module

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
8 months ago
28 days ago

People

(Reporter: yulia, Assigned: yulia)

Tracking

(Blocks 1 bug)

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(2 attachments, 27 obsolete attachments)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
Assignee

Description

8 months ago
The highlighterUtils module is no longer necessary, as the inspector can be instantiated asynchronously, and the inspector front now contains a map of highlighters, as well as cached references to the walker, boxHighlighter, and selection. 

highlighterUtils: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/client/framework/toolbox-highlighter-utils.js#30

inspectorFront: https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/devtools/shared/fronts/inspector.js

call locations: https://searchfox.org/mozilla-central/search?q=highlighterUtils&case=false&regexp=false&path=
Assignee

Comment 4

7 months ago
Depends on D11067
Assignee

Comment 12

7 months ago
Depends on D11075
Assignee

Comment 19

7 months ago
Depends on D11082
Attachment #9025665 - Attachment is obsolete: true
Attachment #9025665 - Attachment is obsolete: false
Assignee

Comment 24

7 months ago
Depends on D12119
Assignee

Comment 26

7 months ago
Depends on D12126
Attachment #9023001 - Attachment is obsolete: true
Attachment #9023004 - Attachment is obsolete: true
Attachment #9022999 - Attachment is obsolete: true
Attachment #9023005 - Attachment is obsolete: true
Attachment #9023006 - Attachment is obsolete: true
Attachment #9023007 - Attachment is obsolete: true
Attachment #9023009 - Attachment is obsolete: true
Attachment #9023010 - Attachment is obsolete: true
Attachment #9023011 - Attachment is obsolete: true
Attachment #9023012 - Attachment is obsolete: true
Attachment #9023013 - Attachment is obsolete: true
Attachment #9023014 - Attachment is obsolete: true
Attachment #9023015 - Attachment is obsolete: true
Attachment #9023016 - Attachment is obsolete: true
Attachment #9023017 - Attachment is obsolete: true
Attachment #9023018 - Attachment is obsolete: true
Attachment #9023019 - Attachment is obsolete: true
Attachment #9023020 - Attachment is obsolete: true
Attachment #9023021 - Attachment is obsolete: true
Assignee

Updated

7 months ago
Depends on: 1508655
Assignee

Updated

7 months ago
Depends on: 1508656
Attachment #9026143 - Attachment is obsolete: true
Attachment #9026145 - Attachment is obsolete: true
Attachment #9025665 - Attachment is obsolete: true
Attachment #9026038 - Attachment is obsolete: true
Attachment #9026039 - Attachment is obsolete: true
Attachment #9026083 - Attachment is obsolete: true
Attachment #9026084 - Attachment is obsolete: true
Assignee

Updated

7 months ago
Depends on: 1508660
Assignee

Comment 30

7 months ago
Depends on D12290
Attachment #9027132 - Attachment is obsolete: true

Comment 31

6 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/140374b098aa
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/01b687bb0b75
remove highlighterUtils documentation from devtools; r=ochameau
Assignee

Comment 33

6 months ago
The fix is on bug 1508660, had to do with rebase conflicts.
Flags: needinfo?(ystartsev)

Comment 34

6 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ae23429e483
remove highlighterUtils from devtools; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/687cf3017ca7
remove highlighterUtils documentation from devtools; r=ochameau

Comment 35

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ae23429e483
https://hg.mozilla.org/mozilla-central/rev/687cf3017ca7
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.