1508710 - test whether symbol dumping actually works

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

This requires us to build dump_syms properly (bug 1497583).  Once we have dump_syms, symbol dumping *probably* works correctly, but we're filing this bug here to note that it does need to be tested and for any potential issues that might crop up.

I am assuming gsvelto will handle this.

Comment 1

[(not currently active) Ted Mielczarek]

We do already have a functional test in unit-symbolstore.py:
https://dxr.mozilla.org/mozilla-central/rev/d6ac0dc85306b753c1d1d5f3084f73f0d1286b86/toolkit/crashreporter/tools/unit-symbolstore.py#457

It runs the whole symbolstore.py script (which runs dump_syms), pointing it at the Firefox binary, and then verifies a few of the FILE lines in the output.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #1)
> We do already have a functional test in unit-symbolstore.py:
> https://dxr.mozilla.org/mozilla-central/rev/
> d6ac0dc85306b753c1d1d5f3084f73f0d1286b86/toolkit/crashreporter/tools/unit-
> symbolstore.py#457
> 
> It runs the whole symbolstore.py script (which runs dump_syms), pointing it
> at the Firefox binary, and then verifies a few of the FILE lines in the
> output.

I think we don't run tests (Python or otherwise) on cross-compiled builds, though?  I mean, that should be fixed, but that also feels like a bit much here.

Comment 3

[(not currently active) Ted Mielczarek]

Correct. We could probably move a few tests like this into a special status and run them on cross-builds. There's nothing in that test that requires running target binaries.

Comment 4

[Gabriele Svelto [:gsvelto]]

Symbols are looking good, see the artifacts here: https://tools.taskcluster.net/groups/ZrRUpz81Ry-Zh5bQz8UP7Q/tasks/ZK7LbAdKSE6l4Fmq9cIH_g/runs/0/artifacts