Closed
Bug 1508710
Opened 5 years ago
Closed 5 years ago
test whether symbol dumping actually works
Categories
(Firefox Build System :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: froydnj, Assigned: gsvelto)
References
(Blocks 1 open bug)
Details
This requires us to build dump_syms properly (bug 1497583). Once we have dump_syms, symbol dumping *probably* works correctly, but we're filing this bug here to note that it does need to be tested and for any potential issues that might crop up. I am assuming gsvelto will handle this.
Comment 1•5 years ago
|
||
We do already have a functional test in unit-symbolstore.py: https://dxr.mozilla.org/mozilla-central/rev/d6ac0dc85306b753c1d1d5f3084f73f0d1286b86/toolkit/crashreporter/tools/unit-symbolstore.py#457 It runs the whole symbolstore.py script (which runs dump_syms), pointing it at the Firefox binary, and then verifies a few of the FILE lines in the output.
Reporter | ||
Comment 2•5 years ago
|
||
(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #1) > We do already have a functional test in unit-symbolstore.py: > https://dxr.mozilla.org/mozilla-central/rev/ > d6ac0dc85306b753c1d1d5f3084f73f0d1286b86/toolkit/crashreporter/tools/unit- > symbolstore.py#457 > > It runs the whole symbolstore.py script (which runs dump_syms), pointing it > at the Firefox binary, and then verifies a few of the FILE lines in the > output. I think we don't run tests (Python or otherwise) on cross-compiled builds, though? I mean, that should be fixed, but that also feels like a bit much here.
Comment 3•5 years ago
|
||
Correct. We could probably move a few tests like this into a special status and run them on cross-builds. There's nothing in that test that requires running target binaries.
Assignee | ||
Comment 4•5 years ago
|
||
Symbols are looking good, see the artifacts here: https://tools.taskcluster.net/groups/ZrRUpz81Ry-Zh5bQz8UP7Q/tasks/ZK7LbAdKSE6l4Fmq9cIH_g/runs/0/artifacts
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•