Closed Bug 1508889 Opened 2 years ago Closed 2 years ago

Allow ipc/chromium (formerly third-party, now forked) to be reformatted, linted, etc.

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set
normal

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: jld, Assigned: jld)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The ipc/chromium tree, with the exception of ipc/chromium/src/third_party, was originally a third-party import, but since 2014 or so we've given up on the idea of ever tracking upstream and have heavily modified it, with the general idea of evolving it into first-class Mozilla code.

So it makes sense to include it in formatting and linting checks.

(It does use Google-style naming conventions, but I don't believe we're linting for that at present.)
The ipc/chromium tree has been forked from its former upstream and
heavily modified, so it's safe to reformat and lint.

However, ipc/chromium/src/third_party (a copy of libevent) is following
its upstream, so that should remain exempt.
See Also: → 1508905
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a615ca514a06
Remove ipc/chromium from the lists of third-party code. r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/a615ca514a06
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Attached patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #9031012 - Flags: approval-mozilla-esr60?
Comment on attachment 9031012 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9031012 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.