Closed Bug 1508905 Opened Last year Closed Last year

Allow dom/media/webaudio/blink to be reformatted with clang-format

Categories

(Core :: Web Audio, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Upstream of this fork has reformatted with clang-format, and so there seems little value in leaving this fork in its original format.  It can be reformatted to the new Mozilla style with clang-format, which will probably be closer to the format upstream is now using.

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp?q=ReverbAccumulationBuffer&sq=package:chromium&dr=CSs&l=37&dlp=chromium&dlf=src/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp&dlc=e7fc592f19c6ffde1296ff01482013a0dd68a977&dlr=13&dlgp=third_party/blink/renderer/platform/audio/reverb_accumulation_buffer.cc&dlgr=chromium/chromium/src&drp=chromium&drf=src/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp&drc=1c8e1a7719e9d223cc84e838c9a31a0210f5878b&drr=14&drgp=third_party/blink/renderer/platform/audio/reverb_accumulation_buffer.cc&drgr=chromium/chromium/src&rcl=1c8e1a7719e9d223cc84e838c9a31a0210f5878b

I don't see any documentation for ThirdPartyPaths.txt, but I guess this is used for other code checking.  Given the differences already between upstream and this fork, I expect the pros of additional static analysis would out-weigh the cons.
Priority: -- → P2
Upstream of this fork has reformatted with clang-format, and so there seems
little value in leaving this fork in its original format.  It can be
reformatted to the new Mozilla style with clang-format, which will probably be
closer to the format upstream is now using.
Given the differences already between upstream and this fork, I expect the pros of additional static analysis would out-weigh the cons.

Depends on D12508
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34e7b9fa3a76
Remove from clang-format-ignore WebAudio files forked from Blink r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/52f4568a2ccd
Include WebAudio files forked from Blink in static-analysis review support r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/34e7b9fa3a76
https://hg.mozilla.org/mozilla-central/rev/52f4568a2ccd
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.