Closed
Bug 1508954
Opened 7 years ago
Closed 7 years ago
Pinned tabs shows on video in fullscreen mode
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | --- | fixed |
People
(Reporter: svanderger, Assigned: mconley)
References
Details
(Keywords: regression)
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Steps to reproduce:
1. Enable classic (non-aero) theme on Windows 7
2. Create new profile
3. Set light theme on about:addons page
4. Open any video (from youtube, for example)
Mozregression pointed on this:
Last good
build_url: https://queue.taskcluster.net/v1/task/KyM6RUuBTouiMU0Qu0casA/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 1ab00b6e99fd65b651381c235f1ae95ed746e57a
pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1ab00b6e99fd65b651381c235f1ae95ed746e57a&tochange=e354a018b703c453e8afcda1f44f1d51456536f5
First bad
build_url: https://queue.taskcluster.net/v1/task/XCgw0ycCTmaBulq9nPft1w/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: e354a018b703c453e8afcda1f44f1d51456536f5
pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c41c4eba7e027bb7cc0735f94be19a8111790dc1&tochange=e354a018b703c453e8afcda1f44f1d51456536f5
![]() |
||
Comment 1•7 years ago
|
||
According to the reporter's comments#0,
Regression window::
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1ab00b6e99fd65b651381c235f1ae95ed746e57a&tochange=e354a018b703c453e8afcda1f44f1d51456536f5
Regressed by: e354a018b703 Mike Conley — Bug 1356920 - Don't calculate and flush layout inside browser-tabsintitlebar.js. r=dao
@Mike,
Your patch seems to cause the regression, Can you please look into this?
Updated•7 years ago
|
Priority: -- → P1
Comment 3•7 years ago
|
||
Hmm, in my case (Debian x64 with KDE) it only happens with the non-default theme and client side decorations enabled.
Comment 4•7 years ago
|
||
I'm guessing the problem is that these rules:
https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/themes/linux/browser.css#646
https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/themes/windows/browser.css#302
https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/themes/windows/compacttheme.css#24
... override this one:
https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/base/content/browser.css#366,372
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #4)
> I'm guessing the problem is that these rules:
>
> https://searchfox.org/mozilla-central/rev/
> 55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/themes/https://searchfox.org/mozilla-central/rev/
>
> https://searchfox.org/mozilla-central/rev/
> 55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/themes/https://searchfox.org/mozilla-central/rev/
>
> https://searchfox.org/mozilla-central/rev/
> 55895c49f55073d82d977cb74ec1d3a71ae4b25f/browser/themes/https://searchfox.org/mozilla-central/rev/
>
Thanks for diagnosing, Dao. These links, however, seem busted - which files and lines do they refer to?
Flags: needinfo?(dao+bmo)
Comment 6•7 years ago
|
||
Apparently bugzilla is broken. Let's see if this simple link works: https://pastebin.com/kzTLGPAX
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 7•7 years ago
|
||
Thanks, dao, got it.
And thanks, Alice0775 White and John for bringing this to our attention.
Assignee: nobody → mconley
Flags: needinfo?(mconley)
Assignee | ||
Comment 9•7 years ago
|
||
![]() |
||
Updated•7 years ago
|
Summary: Pinned tabs shows on video in fullscreen mode on Windows 7 → Pinned tabs shows on video in fullscreen mode
Updated•7 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 11•7 years ago
|
||
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c13be2ae74f1
Avoid accidentally overriding rules that collapse toolbars when in fullscreen mode. r=dao
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 13•7 years ago
|
||
That seems to have done the trick. Thanks everyone.
Updated•7 years ago
|
status-firefox63:
--- → unaffected
status-firefox64:
--- → unaffected
status-firefox-esr60:
--- → unaffected
I can still see that when using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0 ID:20190326214944. Going to file a new bug.
Blocks: 1541796
You need to log in
before you can comment on or make changes to this bug.
Description
•