1541796 - Pinned tabs are shown with video in fullscreen mode

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

+++ This bug was initially created as a clone of Bug #1508954 +++

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0 ID:20190326214944

Steps to reproduce:

1. Open some tabs and pin them
2. Open any video (from youtube, for example)
3. Switch the video into full screen mode

Maybe bug 1508954 only fixed it for Windows, and this is MacOS specific?

Comment 1

[Kestrel]

I'm not seeing this on Ubuntu 18.10 or Windows 10 with latest Nightly 68.0a1 (2019-04-04).

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Interestingly a fresh profile doesn't show the problem. Even restarting with add-ons disabled. But disabling extensions and themes manually, doesn't help in getting away with this problem. Also not after an additional restart.

What else is Restart with Add-ons disabled doing?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Restart with Add-ons Disabled will, I believe, also disable userChrome and userContent stylesheets. Does your profile have either of those set up?

Comment 4

[Dão Gottwald [:dao]]

Safe Mode also doesn't use your modified prefs, does it?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

Restart with Add-ons Disabled will, I believe, also disable userChrome and userContent stylesheets. Does your profile have either of those set up?

Oh, there is indeed an entry in the userChrome.css file:

#navigator-toolbox[inFullscreen] toolbar:not([collapsed="true"]) {
visibility: visible !important;
}

But why do we hide normal tabs but not pinned tabs?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I suspect this a similar case to bug 1508954, and that it's maybe a specificity problem. Check out the patch in https://hg.mozilla.org/mozilla-central/rev/c13be2ae74f1 for clues as to how I fixed it for bug 1508954.

At any rate, I think this is an INVALID bug - this is a case of a userChrome.css overriding some chunks of the browser's default CSS.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Turns out that for whatever reason I added this years ago it's not needed anymore. So removed the CSS override. Thanks!