1508973 - Remove getAnnotationsForItem and unused APIs

Status: RESOLVED FIXED

(Toolkit :: Places, task, P2)

Description

[Marco Bonardo [:mak]]

getAnnotationsForItem is used when copying around nodes, to copy over annotations too. We don't have anymore any item annotation that is worth copying (the only remaining one is for Sync orphans).

Then the following APIs can be removed, afaict:
getItemAnnotationNames, getItemAnnotationInfo

Comment 1

[Mark Banner (:standard8)]

The slight twist here, is that we'll probably need to re-implement annotation extraction for bookmarks export. This will be in BookmarkHTMLUtils.jsm/BookmarkJSONUtils.jsm. This could probably be based on the existing sql but made to be async.

I think there's tests that cover this - they should fail when the code surrounding getAnnotationsForItem is removed.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1508973 - Remove getAnnotationsForItem and unused bookmark annotations APIs. r=Standard8,lina

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe6afadb2f6a
Remove getAnnotationsForItem and unused bookmark annotations APIs. r=Standard8,lina

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fe6afadb2f6a