js/src/jsapi-tests should not be excluded from clang-format

RESOLVED FIXED in Firefox -esr60

Status

()

defect
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
See https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/.clang-format-ignore#16

The C++ files here (at least most of them) are not generated code.
Assignee

Comment 1

6 months ago
(In reply to Jan de Mooij [:jandem] from comment #0)
> See https://searchfox.org/mozilla-central/rev/﷒0

Hm I can't add #16 at the end of this or we get garbage in Bugzilla:

https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/.clang-format-ignore
Assignee

Updated

6 months ago
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED

Comment 4

6 months ago
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d83d28c9ae5
Remove js/src/jsapi-tests from .clang-format-ignore. r=sylvestre,tcampbell

Comment 5

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5d83d28c9ae5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Comment 6

5 months ago
Comment on attachment 9026897 [details]
Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r?sylvestre!,tcampbell!

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #9026897 - Flags: approval-mozilla-esr60?
Comment on attachment 9026897 [details]
Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r?sylvestre!,tcampbell!

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9026897 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.