1509025 - js/src/jsapi-tests should not be excluded from clang-format

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

See https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/.clang-format-ignore#16

The C++ files here (at least most of them) are not generated code.

Comment 1

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #0)
> See https://searchfox.org/mozilla-central/rev/﷒0﷓

Hm I can't add #16 at the end of this or we get garbage in Bugzilla:

https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/.clang-format-ignore

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r?sylvestre!,tcampbell!

Comment 3

[Jan de Mooij [:jandem]]

Result is here, overall looks reasonable:

https://hg.mozilla.org/try/rev/45559de125df7813e42edf3e1e58964265f7deb0

It's nice that it reformats a monster like this:

https://searchfox.org/mozilla-central/rev/8f89901f2d69d9783f946a7458a6d7ee70635a94/js/src/jsapi-tests/testXDR.cpp#113

As:

https://hg.mozilla.org/try/rev/45559de125df7813e42edf3e1e58964265f7deb0#l122.138

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d83d28c9ae5
Remove js/src/jsapi-tests from .clang-format-ignore. r=sylvestre,tcampbell

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5d83d28c9ae5

Comment 6

[(no longer active)]

Comment on attachment 9026897 [details]
Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r?sylvestre!,tcampbell!

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9026897 [details]
Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r?sylvestre!,tcampbell!

OK for uplift to ESR60 as part of the clang-format project.

Comment 8

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/2c67daf9c99b