1509041 - 'Restore previous session' option is active in the hamburger menu after closing the browser with all the tabs selected

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[Gabi Cheta [:Gabi] Desktop QA]

[Affected versions]:
- 65.0a1 (2018-11-20) 
- 64.0b11

[Affected platforms]:
-Ubuntu 16.04
-Windows 10x64
-macOS 10.12

[Steps to reproduce]:
1. Open FF
2. Open a few tabs
3. Select all of the open tabs
4. Right click and choose Close tabs option
5. Confirm close tabs 
6. Reopen Firefox
7. Go to hamburger menu 
8. Click on Restore previous session

[Expected result]:
- Restore previous session should be disabled if closing the browser with the multiselected tabs is considered throwing away the session

[Actual result]:
- Restore previous session is active in the hamburger menu, clicking on it does not restore the tabs closed

Note: Issue seen when closing the browser with all tabs selected with with CTRL+F4 shortcuts also

[Regression range]:
-This issue is not a regression.

Comment 1

[Kestrel]

The session is more than just tabs, it also includes a history of recently closed tabs and windows, so you can restore the session and then recover those closed tabs. Taking away the ability to restore sessions with no tabs means this would no longer be possible.

Comment 2

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Kestrel from comment #1)
> The session is more than just tabs, it also includes a history of recently
> closed tabs and windows, so you can restore the session and then recover
> those closed tabs. Taking away the ability to restore sessions with no tabs
> means this would no longer be possible.

Recently closed tabs and recently closed windows from History are empty, so user cannot restore his previous session, the issue here is that the session restore button is active and clicking on it does nothing when the tabs are closed with the above scenario, if user cannot restore his tabs at least the option should not be available in the hamburger menu.

Comment 3

[Kestrel]

The recently closed tabs list is not empty if you restore the session first.

1. Open FF
2. Open a few tabs
3. Select all of the open tabs
4. Right click and choose Close tabs option
5. Confirm close tabs 
6. Reopen Firefox
7. Go to hamburger menu 
8. Click on Restore previous session
9. Click on Library -> History -> Recently Closed Tabs and choose a tab to restore.
10. Press Ctrl+Shift+T to restore a closed tab.
11. Right click on a tab and choose Undo Close Tab.

Comment 4

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Kestrel from comment #3)
> The recently closed tabs list is not empty if you restore the session first.
> 
> 1. Open FF
> 2. Open a few tabs
> 3. Select all of the open tabs
> 4. Right click and choose Close tabs option
> 5. Confirm close tabs 
> 6. Reopen Firefox
> 7. Go to hamburger menu 
> 8. Click on Restore previous session
> 9. Click on Library -> History -> Recently Closed Tabs and choose a tab to
> restore.
> 10. Press Ctrl+Shift+T to restore a closed tab.
> 11. Right click on a tab and choose Undo Close Tab.

Indeed the recently closed tabs are populated in the Library after hitting the restore previous session button, I was expecting to see the same behaviour as when closing the browser by Exiting or clicking the X button.

Comment 5

[Kestrel]

It's consistent with tab closing behavior, closed tabs are removed from the session, if you want to keep them you close the window or quit through the menu. Chrome has the same behavior, selecting all tabs and closing them means they will not be restored on startup, even if the user has chosen to "continue where you left off".