1509121 - [remote-dbg-next] display error screen if about:devtools-toolbox fails to start

Status: VERIFIED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

about:devtools-toolbox is able to connect to a specific target on a remote client, and does so using URL parameters such as: host, port, type, id...

It is possible to create devtools-toolbox URLs that don't point to any valid runtime or target. In this case we only display a blank tab. We should probably show an error message to the user.

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1509121 - Display error screen if about:devtools-toolbox fails to start. r=jdescottes!, daisuke!

Comment 2

[Belén [:ladybenko]]

Attachment: Bug 1509121 [part 2]: Add test for about:devtools-toolbox error page. r=jdescottes,daisuke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/194d4681c00c
Display error screen if about:devtools-toolbox fails to start. r=jdescottes,daisuke
https://hg.mozilla.org/integration/autoland/rev/3e5099a32d14
[part 2]: Add test for about:devtools-toolbox error page. r=daisuke,jdescottes

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/194d4681c00c
https://hg.mozilla.org/mozilla-central/rev/3e5099a32d14

Comment 5

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 69.0a1 (2019-05-22) and on 68.0b3 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.