Closed Bug 1509121 Opened Last year Closed 10 months ago

[remote-dbg-next] display error screen if about:devtools-toolbox fails to start

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox67 fixed, firefox68 verified, firefox69 verified)

VERIFIED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed
firefox68 --- verified
firefox69 --- verified

People

(Reporter: jdescottes, Assigned: ladybenko)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

about:devtools-toolbox is able to connect to a specific target on a remote client, and does so using URL parameters such as: host, port, type, id...

It is possible to create devtools-toolbox URLs that don't point to any valid runtime or target. In this case we only display a blank tab. We should probably show an error message to the user.
Priority: -- → P2
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: P2 → P1
Blocks: 1505368
Blocks: 1526996
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/194d4681c00c
Display error screen if about:devtools-toolbox fails to start. r=jdescottes,daisuke
https://hg.mozilla.org/integration/autoland/rev/3e5099a32d14
[part 2]: Add test for about:devtools-toolbox error page. r=daisuke,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Verified as fixed on Firefox Nightly 69.0a1 (2019-05-22) and on 68.0b3 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.