1505368 - [remote-dbg-next] about:devtools-toolbox should not navigate to about:blank when the target is destroyed

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Julian Descottes [:jdescottes]]

+++ This bug was initially created as a clone of Bug #1497452 +++

Comment 1

[Julian Descottes [:jdescottes]]

I think we can unblock this from UX work. We should here simply make sure we don't navigate and display an error message similar to what we be done in Bug 1509121

Comment 2

[Julian Descottes [:jdescottes]]

thanks for adding the dependency on Bug 1509121 !

Comment 3

[Julian Descottes [:jdescottes]]

Unassigning, we discussed earlier that this would be a good fit for :ladybenko after Bug 1509121 .

Comment 4

[Daisuke Akatsuka (:daisuke)]

Agree!

Comment 5

[Belén [:ladybenko]]

Attachment: Bug 1505368 - Show error page in about:devtools-toolbox when target is destroyed

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a14e5a146b8d
Show error page in about:devtools-toolbox when target is destroyed r=jdescottes,daisuke

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for causing asan devtools failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d64cfe30769af8f543ac5259542baa7d304e082b
Push link: https://hg.mozilla.org/integration/autoland/rev/a14e5a146b8dcfe063a91f0c0e435e0bf42b0613
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235050158&repo=autoland&lineNumber=2156

Comment 9

[Belén [:ladybenko]]

We're investigating whether the cause is the implementation or the introduced test, that may be surfacing an already-existing problem.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b147830dc59e
Show error page in about:devtools-toolbox when target is destroyed r=jdescottes,daisuke

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out for devtools node failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=b147830dc59ed33e2cf9973e211e8547590807d3&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-devtools-tests%2Cnode%28devtools%29&selectedJob=238099265

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238099265&repo=autoland&lineNumber=417

Backout link: https://hg.mozilla.org/integration/autoland/rev/2c261b95d855b3f61595342fdce6cd64fd1f1cc1

Failure snippet:

[task 2019-04-04T10:48:58.477Z] yarn install v1.9.4
[task 2019-04-04T10:48:58.574Z] [1/5] Validating package.json...
[task 2019-04-04T10:48:58.577Z] [2/5] Resolving packages...
[task 2019-04-04T10:48:59.082Z] [3/5] Fetching packages...
[task 2019-04-04T10:48:59.738Z] info fsevents@1.2.7: The platform "linux" is incompatible with this module.
[task 2019-04-04T10:48:59.738Z] info "fsevents@1.2.7" is an optional dependency and failed compatibility check. Excluding it from installation.
[task 2019-04-04T10:48:59.749Z] [4/5] Linking dependencies...
[task 2019-04-04T10:49:02.961Z] [5/5] Building fresh packages...
[task 2019-04-04T10:49:02.981Z] Done in 4.51s.
[task 2019-04-04T10:49:02.992Z] + yarn test
[task 2019-04-04T10:49:03.384Z] yarn run v1.9.4
[task 2019-04-04T10:49:03.472Z] $ jest
[task 2019-04-04T10:49:06.500Z] FAIL components/debug-target-info.test.js
[task 2019-04-04T10:49:06.501Z] DebugTargetInfo component
[task 2019-04-04T10:49:06.502Z] ✓ displays connection info for USB Release target (19ms)
[task 2019-04-04T10:49:06.502Z] ✕ renders the expected snapshot for USB Release target (19ms)
[task 2019-04-04T10:49:06.502Z] ✓ hides the connection info for This Firefox target (8ms)
[task 2019-04-04T10:49:06.502Z] ✓ displays the target title if the target of the Toolbox has a name (1ms)
[task 2019-04-04T10:49:06.502Z] ✕ renders the expected snapshot for This Firefox target (2ms)
[task 2019-04-04T10:49:06.502Z] ✓ doesn't display the target title if the target of the Toolbox has no name (1ms)
[task 2019-04-04T10:49:06.502Z] ✕ renders the expected snapshot for a Toolbox with an unnamed target (2ms)
[task 2019-04-04T10:49:06.502Z]
[task 2019-04-04T10:49:06.502Z] ● DebugTargetInfo component › renders the expected snapshot for USB Release target
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] expect(value).toMatchSnapshot()
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] Received value does not match stored snapshot "DebugTargetInfo component renders the expected snapshot for USB Release target 1".
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] - Snapshot
[task 2019-04-04T10:49:06.503Z] + Received
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] @@ -1,7 +1,7 @@
[task 2019-04-04T10:49:06.503Z] <header
[task 2019-04-04T10:49:06.503Z] - className="debug-target-info"
[task 2019-04-04T10:49:06.503Z] + className="debug-target-info js-debug-target-info"
[task 2019-04-04T10:49:06.503Z] >
[task 2019-04-04T10:49:06.503Z] <span
[task 2019-04-04T10:49:06.503Z] className="iconized-label js-connection-info"
[task 2019-04-04T10:49:06.503Z] >
[task 2019-04-04T10:49:06.503Z] <img
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] 81 | it("renders the expected snapshot for USB Release target", () => {
[task 2019-04-04T10:49:06.503Z] 82 | const targetInfo = renderer.create(USB_TARGET_INFO);
[task 2019-04-04T10:49:06.503Z] > 83 | expect(targetInfo.toJSON()).toMatchSnapshot();
[task 2019-04-04T10:49:06.503Z] | ^
[task 2019-04-04T10:49:06.503Z] 84 | });
[task 2019-04-04T10:49:06.503Z] 85 |
[task 2019-04-04T10:49:06.503Z] 86 | it("hides the connection info for This Firefox target", () => {
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] at Object.toMatchSnapshot (components/debug-target-info.test.js:83:33)
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] ● DebugTargetInfo component › renders the expected snapshot for This Firefox target
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.503Z] expect(value).toMatchSnapshot()
[task 2019-04-04T10:49:06.503Z]
[task 2019-04-04T10:49:06.504Z] Received value does not match stored snapshot "DebugTargetInfo component renders the expected snapshot for This Firefox target 1".
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] - Snapshot
[task 2019-04-04T10:49:06.504Z] + Received
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] @@ -1,7 +1,7 @@
[task 2019-04-04T10:49:06.504Z] <header
[task 2019-04-04T10:49:06.504Z] - className="debug-target-info"
[task 2019-04-04T10:49:06.504Z] + className="debug-target-info js-debug-target-info"
[task 2019-04-04T10:49:06.504Z] >
[task 2019-04-04T10:49:06.504Z] <span
[task 2019-04-04T10:49:06.504Z] className="iconized-label"
[task 2019-04-04T10:49:06.504Z] >
[task 2019-04-04T10:49:06.504Z] <img
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] 96 | it("renders the expected snapshot for This Firefox target", () => {
[task 2019-04-04T10:49:06.504Z] 97 | const targetInfo = renderer.create(THIS_FIREFOX_TARGET_INFO);
[task 2019-04-04T10:49:06.504Z] > 98 | expect(targetInfo.toJSON()).toMatchSnapshot();
[task 2019-04-04T10:49:06.504Z] | ^
[task 2019-04-04T10:49:06.504Z] 99 | });
[task 2019-04-04T10:49:06.504Z] 100 |
[task 2019-04-04T10:49:06.504Z] 101 | it("doesn't display the target title if the target of the Toolbox has no name", () => {
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] at Object.toMatchSnapshot (components/debug-target-info.test.js:98:33)
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] ● DebugTargetInfo component › renders the expected snapshot for a Toolbox with an unnamed target
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] expect(value).toMatchSnapshot()
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] Received value does not match stored snapshot "DebugTargetInfo component renders the expected snapshot for a Toolbox with an unnamed target 1".
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] - Snapshot
[task 2019-04-04T10:49:06.504Z] + Received
[task 2019-04-04T10:49:06.504Z]
[task 2019-04-04T10:49:06.504Z] @@ -1,7 +1,7 @@
[task 2019-04-04T10:49:06.504Z] <header
[task 2019-04-04T10:49:06.504Z] - className="debug-target-info"
[task 2019-04-04T10:49:06.504Z] + className="debug-target-info js-debug-target-info"
[task 2019-04-04T10:49:06.504Z] >
[task 2019-04-04T10:49:06.504Z] <span
[task 2019-04-04T10:49:06.504Z] className="iconized-label"
[task 2019-04-04T10:49:06.504Z] >
[task 2019-04-04T10:49:06.505Z] <img
[task 2019-04-04T10:49:06.505Z]
[task 2019-04-04T10:49:06.505Z] 106 | it("renders the expected snapshot for a Toolbox with an unnamed target", () => {
[task 2019-04-04T10:49:06.505Z] 107 | const targetInfo = renderer.create(THIS_FIREFOX_NO_NAME_TARGET_INFO);
[task 2019-04-04T10:49:06.505Z] > 108 | expect(targetInfo.toJSON()).toMatchSnapshot();
[task 2019-04-04T10:49:06.505Z] | ^
[task 2019-04-04T10:49:06.505Z] 109 | });
[task 2019-04-04T10:49:06.505Z] 110 | });
[task 2019-04-04T10:49:06.505Z] 111 |
[task 2019-04-04T10:49:06.505Z]
[task 2019-04-04T10:49:06.505Z] at Object.toMatchSnapshot (components/debug-target-info.test.js:108:33)
[task 2019-04-04T10:49:06.505Z]
[task 2019-04-04T10:49:06.505Z] › 3 snapshots failed.
[task 2019-04-04T10:49:06.507Z] Snapshot Summary
[task 2019-04-04T10:49:06.507Z] › 3 snapshots failed from 1 test suite. Inspect your code changes or run yarn test -u to update them.
[task 2019-04-04T10:49:06.507Z]
[task 2019-04-04T10:49:06.508Z] Test Suites: 1 failed, 1 total
[task 2019-04-04T10:49:06.508Z] Tests: 3 failed, 4 passed, 7 total
[task 2019-04-04T10:49:06.508Z] Snapshots: 3 failed, 3 total
[task 2019-04-04T10:49:06.508Z] Time: 2.389s
[task 2019-04-04T10:49:06.508Z] Ran all test suites.
[task 2019-04-04T10:49:06.568Z] error Command failed with exit code 1.
[task 2019-04-04T10:49:06.568Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[taskcluster 2019-04-04 10:49:07.218Z] === Task Finished ===
[taskcluster 2019-04-04 10:49:07.219Z] Unsuccessful task run with exit code: 1 completed in 354.925 seconds

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e4f040f66b7
Show error page in about:devtools-toolbox when target is destroyed r=jdescottes,daisuke

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6e4f040f66b7

Comment 14

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 69.0a1 (2019-05-29) and on Firefox 68.0b5 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.