1509155 - Disable GDI fonts

Status: NEW

(Core :: Graphics: Text, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

We shouldn't need to use GDI fonts anywhere. It would be nice to delete all of that code.

This would also let us avoid having to pass a DrawTarget to gfxFont::GetGlyphWidth() which will let us avoid threading it around a bunch of places.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Jonathan or Lee do you know any reason we shouldn't do this?

Comment 2

[Jonathan Kew [:jfkthame]]

It would be nice to get rid of the GDI font code, but I'm a bit concerned we may still be depending on it as a fallback when (for reasons unknown) we fail to use directwrite. E.g. the crash in bug 1505966 appeared to be caused by a failure to get the dwrite system font collection, so we needed to fix the handling of that failure (and we'd then fall back to GDI).

If we remove the GDI font code, our only option on failing to initialize dwrite would be to refuse to run at all. I don't know how frequent that scenario is; maybe we should add some telemetry to find out?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

My initial look at DWRITEFONT_INIT_PROBLEM telemetry suggests we're hitting this on .03% of windows beta users. I'll look more closely at the numbers and confirm.

Comment 4

[Lee Salzman [:lsalzman]]

That would be the main fear, yes, that we are falling back to GDI if DWrite for some reason fails.