1509297 - TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-plugin-blocked.js | test-plugin-blocked.js::test_blocklisted_plugin_notification

Status: RESOLVED WONTFIX

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-plugin-blocked.js | test-plugin-blocked.js::test_blocklisted_plugin_notification

M-C last good: ad8114bf526cfa7c4e878bc6cb48dc582d
M-C first bad: 785032241b2fe327aa833267416b3eb8d8
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ad8114bf526cfa7c4e878bc6cb48dc582d&tochange=785032241b2fe327aa833267416b3eb8d8

In that range, the only bug with "plugin" in the commit message is bug 1497940.

https://taskcluster-artifacts.net/RP94oXH3QweFqDAyIwvMZg/0/public/logs/live_backing.log says:
INFO -  SUMMARY-UNEXPECTED-FAIL | test-plugin-blocked.js | test-plugin-blocked.js::test_blocklisted_plugin_notification
INFO -    EXCEPTION: Plugin test taking too long
INFO -      at: utils.js line 396
INFO -         TimeoutError utils.js:396 13
INFO -         waitFor utils.js:452 11
INFO -         MozMillController.prototype.waitFor controller.js:687 3
INFO -         test_blocklisted_plugin_notification test-plugin-blocked.js:75 3

Maybe we don't detect something now due to changes in
https://hg.mozilla.org/mozilla-central/rev/2eeaf4aca069
https://hg.mozilla.org/mozilla-central/rev/5f543ba66e2c

Running
mozmake SOLO_TEST=content-tabs/test-plugin-blocked.js mozmill-one
manually I see
JavaScript error: chrome://mozmill/content/modules/utils.js, line 396: TimeoutError: Timeout waiting for alert
and I don't see any notification.

Comment 1

[Jorg K (CEST = GMT+2)]

Confirmed via local backout of bug 1497940. With that backed out, I see a big notification.

https://dxr.mozilla.org/comm-central/search?q=pluginGeneric.svg&redirect=false
shows that we need to port changes from here:
https://hg.mozilla.org/mozilla-central/rev/2eeaf4aca069#l3.12
and maybe more.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1509297-plugin-path.patch

This should fix this failures.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9026945 [details] [diff] [review]
1509297-plugin-path.patch

Surely this is the right thing to do, but it doesn't make the test work. Same timeout and no visible notification. I know you don't run tests, but in fact you could by adding
  ac_add_options --enable-tests
to mozconfig and then using
  mozmake SOLO_TEST=content-tabs/test-plugin-blocked.js mozmill-one
in the object directory. Then you'd see that the notification is completely missing.

Comment 4

[Richard Marti (:Paenglab)]

Then maybe it needs some port from https://hg.mozilla.org/mozilla-central/rev/5f543ba66e2c.

Comment 5

[Jorg K (CEST = GMT+2)]

Richard told me to try dom.ua_widget.enabled=false. That in fact worked.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1509297-plugin-path.patch (v2)

I added the pref and will land this now. Aceman, can you adapt the test to the new scheme please.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0144b5d6b006
Fix the path to the plugin SVG files after bug 1497940 and add pref dom.ua_widget.enabled. r=jorgk CLOSED TREE DONTBUILD

Comment 8

[:aceman]

New scheme? The "UA Widget", whatever it is?

Comment 9

[Jorg K (CEST = GMT+2)]

Yes, like in https://hg.mozilla.org/mozilla-central/rev/5f543ba66e2c, but careful, maybe we're removing all the plugin stuff anyway, see bug 1508942. Maybe no need to do anything since it will all get ripped out?

Comment 10

[:aceman]

Yes, it seems the whole test-plugin-blocked.js was removed in bug 1508942.

Comment 11

[Geoff Lankow (:darktrojan)]

I'm here to help. :)

Comment 12

[Jorg K (CEST = GMT+2)]

And what about the dom.ua_widget.enabled pref? We can remove that again, right?

Comment 13

[Jorg K (CEST = GMT+2)]

Oh, already gone. Thanks:
https://hg.mozilla.org/comm-central/rev/61f67f491dd7#l1.76