Closed Bug 1509297 Opened 11 months ago Closed 11 months ago
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-plugin-blocked
.js | test-plugin-blocked .js::test _blocklisted _plugin _notification
Confirmed via local backout of bug 1497940. With that backed out, I see a big notification. https://dxr.mozilla.org/comm-central/search?q=pluginGeneric.svg&redirect=false shows that we need to port changes from here: https://hg.mozilla.org/mozilla-central/rev/2eeaf4aca069#l3.12 and maybe more.
This should fix this failures.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9026945 - Flags: review?(jorgk)
Comment on attachment 9026945 [details] [diff] [review] 1509297-plugin-path.patch Surely this is the right thing to do, but it doesn't make the test work. Same timeout and no visible notification. I know you don't run tests, but in fact you could by adding ac_add_options --enable-tests to mozconfig and then using mozmake SOLO_TEST=content-tabs/test-plugin-blocked.js mozmill-one in the object directory. Then you'd see that the notification is completely missing.
Attachment #9026945 - Flags: review?(jorgk) → review+
Then maybe it needs some port from https://hg.mozilla.org/mozilla-central/rev/5f543ba66e2c.
Assignee: richard.marti → nobody
Status: ASSIGNED → NEW
Richard told me to try dom.ua_widget.enabled=false. That in fact worked.
I added the pref and will land this now. Aceman, can you adapt the test to the new scheme please.
Assignee: nobody → jorgk
Attachment #9026985 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/0144b5d6b006 Fix the path to the plugin SVG files after bug 1497940 and add pref dom.ua_widget.enabled. r=jorgk CLOSED TREE DONTBUILD
New scheme? The "UA Widget", whatever it is?
Yes, like in https://hg.mozilla.org/mozilla-central/rev/5f543ba66e2c, but careful, maybe we're removing all the plugin stuff anyway, see bug 1508942. Maybe no need to do anything since it will all get ripped out?
Yes, it seems the whole test-plugin-blocked.js was removed in bug 1508942.
I'm here to help. :)
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → WONTFIX
And what about the dom.ua_widget.enabled pref? We can remove that again, right?
Target Milestone: --- → Thunderbird 65.0
Oh, already gone. Thanks: https://hg.mozilla.org/comm-central/rev/61f67f491dd7#l1.76
You need to log in before you can comment on or make changes to this bug.