Closed Bug 1509309 Opened 11 months ago Closed 11 months ago

Move most browser-*.js scripts from global-scripts.inc to browser.xul

Categories

(Firefox :: General, enhancement, P3)

All
macOS
enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

It looks like we load way too many scripts from global-scripts.inc that seem to make no sense outside of browser.xul.
See Also: → 1509029
Summary: Move more browser-*.js scripts from global-scripts.inc to browser.xul → Move most browser-*.js scripts from global-scripts.inc to browser.xul
Attachment #9026953 - Attachment description: Bug 1509309 - Move more browser-*.js scripts from global-scripts.inc to browser.xul. → Bug 1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul.
I'm getting various ESLint failures that I'm having a hard time making sense of:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6592261dd596478eb3b0c67e248977a92558975&selectedJob=213560810

Mark, do you see what's wrong or missing?
Flags: needinfo?(standard8)
Sorry for the delay in getting to this. ESLint wasn't finding the globals after your changes. I tracked this down to the regexp:

/Services.scriptloader.loadSubScript(\"(.*?)\", this);/

You need to escape the brackets for the function call.

I'd also prefer it if we could scan both browser.xul and global-scripts.inc for the files, rather than just one of them. I realise that's a little more work, but I think it would be easier for maintenance long term. If you haven't got time, let me know and I can try and fit it in.
Flags: needinfo?(standard8)
(In reply to Mark Banner (:standard8) from comment #4)
> Sorry for the delay in getting to this. ESLint wasn't finding the globals
> after your changes. I tracked this down to the regexp:
> 
> /Services.scriptloader.loadSubScript(\"(.*?)\", this);/
> 
> You need to escape the brackets for the function call.

D'oh, thanks.

> I'd also prefer it if we could scan both browser.xul and global-scripts.inc
> for the files, rather than just one of them. I realise that's a little more
> work, but I think it would be easier for maintenance long term. If you
> haven't got time, let me know and I can try and fit it in.

Looking into this.
Attachment #9026953 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e1161b3716a
Move most browser-*.js scripts from global-scripts.inc to browser.xul. r=Standard8
https://hg.mozilla.org/mozilla-central/rev/5e1161b3716a
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Blocks: 1510579
You need to log in before you can comment on or make changes to this bug.