1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Dão Gottwald [:dao]]

It looks like we load way too many scripts from global-scripts.inc that seem to make no sense outside of browser.xul.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul.

Comment 2

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20707c9ca184b423969e07390426215b38743796

Comment 3

[Dão Gottwald [:dao]]

I'm getting various ESLint failures that I'm having a hard time making sense of:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6592261dd596478eb3b0c67e248977a92558975&selectedJob=213560810

Mark, do you see what's wrong or missing?

Comment 4

[Mark Banner (:standard8)]

Sorry for the delay in getting to this. ESLint wasn't finding the globals after your changes. I tracked this down to the regexp:

/Services.scriptloader.loadSubScript(\"(.*?)\", this);/

You need to escape the brackets for the function call.

I'd also prefer it if we could scan both browser.xul and global-scripts.inc for the files, rather than just one of them. I realise that's a little more work, but I think it would be easier for maintenance long term. If you haven't got time, let me know and I can try and fit it in.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Mark Banner (:standard8) from comment #4)
> Sorry for the delay in getting to this. ESLint wasn't finding the globals
> after your changes. I tracked this down to the regexp:
> 
> /Services.scriptloader.loadSubScript(\"(.*?)\", this);/
> 
> You need to escape the brackets for the function call.

D'oh, thanks.

> I'd also prefer it if we could scan both browser.xul and global-scripts.inc
> for the files, rather than just one of them. I realise that's a little more
> work, but I think it would be easier for maintenance long term. If you
> haven't got time, let me know and I can try and fit it in.

Looking into this.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul. r=Standard8

Comment 7

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bed68a7aed710cebe487dc63f91f7eb3e0e8cb9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e1161b3716a
Move most browser-*.js scripts from global-scripts.inc to browser.xul. r=Standard8

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5e1161b3716a