Closed
Bug 1509309
Opened 6 years ago
Closed 6 years ago
Move most browser-*.js scripts from global-scripts.inc to browser.xul
Categories
(Firefox :: General, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
It looks like we load way too many scripts from global-scripts.inc that seem to make no sense outside of browser.xul.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20707c9ca184b423969e07390426215b38743796
Assignee | ||
Updated•6 years ago
|
Summary: Move more browser-*.js scripts from global-scripts.inc to browser.xul → Move most browser-*.js scripts from global-scripts.inc to browser.xul
Updated•6 years ago
|
Attachment #9026953 -
Attachment description: Bug 1509309 - Move more browser-*.js scripts from global-scripts.inc to browser.xul. → Bug 1509309 - Move most browser-*.js scripts from global-scripts.inc to browser.xul.
Assignee | ||
Comment 3•6 years ago
|
||
I'm getting various ESLint failures that I'm having a hard time making sense of: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6592261dd596478eb3b0c67e248977a92558975&selectedJob=213560810 Mark, do you see what's wrong or missing?
Flags: needinfo?(standard8)
Comment 4•6 years ago
|
||
Sorry for the delay in getting to this. ESLint wasn't finding the globals after your changes. I tracked this down to the regexp: /Services.scriptloader.loadSubScript(\"(.*?)\", this);/ You need to escape the brackets for the function call. I'd also prefer it if we could scan both browser.xul and global-scripts.inc for the files, rather than just one of them. I realise that's a little more work, but I think it would be easier for maintenance long term. If you haven't got time, let me know and I can try and fit it in.
Flags: needinfo?(standard8)
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #4) > Sorry for the delay in getting to this. ESLint wasn't finding the globals > after your changes. I tracked this down to the regexp: > > /Services.scriptloader.loadSubScript(\"(.*?)\", this);/ > > You need to escape the brackets for the function call. D'oh, thanks. > I'd also prefer it if we could scan both browser.xul and global-scripts.inc > for the files, rather than just one of them. I realise that's a little more > work, but I think it would be easier for maintenance long term. If you > haven't got time, let me know and I can try and fit it in. Looking into this.
Assignee | ||
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Attachment #9026953 -
Attachment is obsolete: true
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bed68a7aed710cebe487dc63f91f7eb3e0e8cb9
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e1161b3716a Move most browser-*.js scripts from global-scripts.inc to browser.xul. r=Standard8
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e1161b3716a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•