1509029 - [meta] browser-*.js global-scope pollution

Status: RESOLVED FIXED

(Firefox :: General, task, P5)

Description

[Dão Gottwald [:dao]]

browser-*.js scripts are often seen as self-contained when they're really not (they share the browser window scope with loads of other scripts), leading people to think it would be reasonable to put their helper stuff in their "private" scope just like they would in a jsm. Then somebody else sees that the thing they want to use is already defined and reuse it in some other script running in the browser window, leading to weird dependencies that are annoying when refactoring or moving code, or they don't see it and redeclare it (possibly with some other value when things are named too generically).

Filing this meta bug for this reoccurring code hygiene issue as a way to provide context so that I won't have to repeatedly explain it.

Comment 1

[Jan de Mooij [:jandem]]

Sylvestre, is the bot moving all "JavaScript" bugs into the JS Engine component? That seems wrong.

Comment 2

[Marco Castelluccio [:marco]]

Pretty sure the problem here was the mention of JavaScript and global and scope, which are often linked to JavaScript bugs.
Also, comment 0 is empty and the info is in the user story (which is pretty rare).

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

This come up during General triage, all bugs tracked are marked as closed and so we are closing the meta, feel to reopen if there is still work ongoing.