1509464 - Remove PlacesUtils.setAnnotationsForItem

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P2)

Description

[Mark Banner (:standard8)]

Following bug 1489409, we should be close enough to removing PlacesUtils.setAnnotationsForItem completely.

We no longer need to save annotations for transactions (in createItemsFromBookmarksTree), and we don't need to handle transactions when we're inserting a tree (via handleBookmarkItemSpecialData).

Comment 1

[Mark Banner (:standard8)]

Alex is going to look at this.

Comment 2

[Mark Banner (:standard8)]

Note: The relevant tests to run for these are in toolkit/components/places and browser/components/places.

Doing these should be enough (unless you spot other instances outside these directories in the code base, then just fix those & run the appropriate test):

./mach xpcshell-test toolkit/components/places
./mach mochitest toolkit/components/places
./mach xpcshell-test browser/components/places
./mach mochitest browser/components/places

test_utils_setAnnotationsForItem.js can be removed completely.

Comment 3

[Manish [:manishkk]]

need to remove all of these?
https://searchfox.org/mozilla-central/search?q=PlacesUtils.setAnnotationsForItem&path=

(In reply to Mark Banner (:standard8) (afk until Friday) from comment #2)

Note: The relevant tests to run for these are in toolkit/components/places and browser/components/places.

Doing these should be enough (unless you spot other instances outside these directories in the code base, then just fix those & run the appropriate test):

./mach xpcshell-test toolkit/components/places
./mach mochitest toolkit/components/places
./mach xpcshell-test browser/components/places
./mach mochitest browser/components/places

test_utils_setAnnotationsForItem.js can be removed completely.

Comment 4

[Mark Banner (:standard8)]

(In reply to Manish [:manishkk][Less Active until 24 Feb] from comment #3)

need to remove all of these?
https://searchfox.org/mozilla-central/search?q=PlacesUtils.setAnnotationsForItem&path=

Yes that is the case, but please leave this bug for Alex as per the assignee field. He was stalled for various reasons but is hoping to do this soon.

Comment 5

[Mark Banner (:standard8)]

Passing over to Mihir, as Alex isn't able to work on this for a while.

Comment 6

[mihir17166]

Attachment: Bug 1509464 - Remove PlacesUtils.setAnnotationsForItem. r?Standard8

Comment 7

[mihir17166]

Attachment: Bug 1509464 - Remove PlacesUtils.setAnnotationsForItem. r?Standard8

Depends on D24260

Comment 8

[mihir17166]

Attachment: Bug 1509464 - Remove PlacesUtils.setAnnotationsForItem. r?Standard8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03162ab7285e
Remove PlacesUtils.setAnnotationsForItem. r=Standard8

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/03162ab7285e

Comment 11

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/03162ab7285e0e8d8914bdb793b44bafb8304e5b
Bug 1509464 - Remove PlacesUtils.setAnnotationsForItem. r=Standard8