Remove PlacesUtils.setAnnotationsForItem
Categories
(Toolkit :: Places, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: standard8, Assigned: mihir17166, Mentored)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file, 2 obsolete files)
Following bug 1489409, we should be close enough to removing PlacesUtils.setAnnotationsForItem completely. We no longer need to save annotations for transactions (in createItemsFromBookmarksTree), and we don't need to handle transactions when we're inserting a tree (via handleBookmarkItemSpecialData).
Reporter | ||
Comment 1•4 years ago
|
||
Alex is going to look at this.
Reporter | ||
Comment 2•4 years ago
|
||
Note: The relevant tests to run for these are in toolkit/components/places and browser/components/places.
Doing these should be enough (unless you spot other instances outside these directories in the code base, then just fix those & run the appropriate test):
./mach xpcshell-test toolkit/components/places
./mach mochitest toolkit/components/places
./mach xpcshell-test browser/components/places
./mach mochitest browser/components/places
test_utils_setAnnotationsForItem.js can be removed completely.
Comment 3•4 years ago
|
||
need to remove all of these?
https://searchfox.org/mozilla-central/search?q=PlacesUtils.setAnnotationsForItem&path=
(In reply to Mark Banner (:standard8) (afk until Friday) from comment #2)
Note: The relevant tests to run for these are in toolkit/components/places and browser/components/places.
Doing these should be enough (unless you spot other instances outside these directories in the code base, then just fix those & run the appropriate test):
./mach xpcshell-test toolkit/components/places
./mach mochitest toolkit/components/places
./mach xpcshell-test browser/components/places
./mach mochitest browser/components/placestest_utils_setAnnotationsForItem.js can be removed completely.
Reporter | ||
Comment 4•4 years ago
|
||
(In reply to Manish [:manishkk][Less Active until 24 Feb] from comment #3)
need to remove all of these?
https://searchfox.org/mozilla-central/search?q=PlacesUtils.setAnnotationsForItem&path=
Yes that is the case, but please leave this bug for Alex as per the assignee field. He was stalled for various reasons but is hoping to do this soon.
Reporter | ||
Comment 5•4 years ago
|
||
Passing over to Mihir, as Alex isn't able to work on this for a while.
Assignee | ||
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D24260
Assignee | ||
Comment 8•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03162ab7285e Remove PlacesUtils.setAnnotationsForItem. r=Standard8
Comment 10•4 years ago
|
||
bugherder |
Comment 11•4 years ago
|
||
https://hg.mozilla.org/projects/ash/rev/03162ab7285e0e8d8914bdb793b44bafb8304e5b Bug 1509464 - Remove PlacesUtils.setAnnotationsForItem. r=Standard8
Description
•