1509469 - Remove unused ContentAreaUtils.ioService

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P5)

Description

[Dão Gottwald [:dao]]

The comment says we kept this "for backwards compatibility", but this can't anymore be accessed from external code such as add-ons:

https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/toolkit/content/contentAreaUtils.js#22-27

Comment 1

[Hrushikesh Bodas]

I would like to take this up.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Hrushikesh Bodas from comment #1)
> I would like to take this up.

Go ahead! Let me know if you have questions.

Comment 3

[Hrushikesh Bodas]

I have a doubt on this... Where do I get the code from? Github says that the repository is retired.

Comment 4

[Dão Gottwald [:dao]]

There's a github mirror: https://github.com/mozilla/gecko-dev

However it is recommended that you use Mercurial: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code

Here's how to submit a patch: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 5

[Ferenc Nagy]

@Hrushikesh Bodas : Are you still working on this?

Comment 6

[Hrushikesh Bodas]

Yea I am still working on this bug. I'm wait for a stable internet connection which I will get by today evening.

Comment 7

[Hrushikesh Bodas]

@Dão Gottwald Which repo should i clone in mercurial? Also how can i contact you on IRC?

Comment 8

[Hrushikesh Bodas]

::dao I have removed the lines and made local changes to the repository.

Comment 9

[Hrushikesh Bodas]

::dao I am trying to push the changes to the repo with the error authorization failed. I read your message on How to Submit a patch.
Also please assign this bug to me

Comment 10

[Dão Gottwald [:dao]]

(In reply to Hrushikesh Bodas from comment #9)
> ::dao I am trying to push the changes to the repo with the error
> authorization failed. I read your message on How to Submit a patch.

How exactly did you try to push the patch?

Comment 11

[Hrushikesh Bodas]

::dao there was an error in my configuration of arcainst. I'm still working on getting the setup right.

Comment 12

[Hrushikesh Bodas]

I have made the changes and after a troubling setup, applied for review... on phabricator mozilla, it shows that reviewers have not been specified.

Comment 13

[Hrushikesh Bodas]

Attachment: Bug 1509469 Remove unused ContentAreaUtils.ioService

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cec394267904
Remove unused ContentAreaUtils.ioService r=dao

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/cec394267904