Remove unused ContentAreaUtils.ioService

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P5
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: dao, Assigned: hrushikeshcoc, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
The comment says we kept this "for backwards compatibility", but this can't anymore be accessed from external code such as add-ons:

https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/toolkit/content/contentAreaUtils.js#22-27
(Assignee)

Comment 1

5 months ago
I would like to take this up.
(Reporter)

Comment 2

5 months ago
(In reply to Hrushikesh Bodas from comment #1)
> I would like to take this up.

Go ahead! Let me know if you have questions.
(Assignee)

Comment 3

5 months ago
I have a doubt on this... Where do I get the code from? Github says that the repository is retired.

Comment 5

5 months ago
@Hrushikesh Bodas : Are you still working on this?
(Assignee)

Comment 6

5 months ago
Yea I am still working on this bug. I'm wait for a stable internet connection which I will get by today evening.
(Assignee)

Comment 7

5 months ago
@Dão Gottwald Which repo should i clone in mercurial? Also how can i contact you on IRC?
(Assignee)

Comment 8

5 months ago
::dao I have removed the lines and made local changes to the repository.
(Assignee)

Comment 9

5 months ago
::dao I am trying to push the changes to the repo with the error authorization failed. I read your message on How to Submit a patch.
Also please assign this bug to me
(Reporter)

Comment 10

5 months ago
(In reply to Hrushikesh Bodas from comment #9)
> ::dao I am trying to push the changes to the repo with the error
> authorization failed. I read your message on How to Submit a patch.

How exactly did you try to push the patch?
Assignee: nobody → hrushikeshcoc
Priority: -- → P5
(Assignee)

Comment 11

5 months ago
::dao there was an error in my configuration of arcainst. I'm still working on getting the setup right.
(Assignee)

Comment 12

5 months ago
I have made the changes and after a troubling setup, applied for review... on phabricator mozilla, it shows that reviewers have not been specified.

Comment 14

5 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cec394267904
Remove unused ContentAreaUtils.ioService r=dao

Comment 15

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cec394267904
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.