1509614 - [mozdevice] Downgrade the log level for get_process_list() if this isn't the final attempt.

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bug 1466657 made get_process_list() make more than one attempt to set up adb correctly, which usually helps. 

But while the loop is running, failure to set up adb is logged as an error, even if this isn't the final attempt to set it up before aborting. This makes the error line show up in Treeherder's logviewer, which can result in this getting marked as an intermittent failure in bugzilla.

The error is logged as printed out as `adb get_process_list:`. In most cases besides the x86 emulators, this message should also include the headers that `ps` returns as debugging information, but for the x86 emulators, `ps` is still sometimes returning the empty string.

I'd argue that this should only be printed with a loglevel of ERROR if this is the final attempt at setting up adb. If this isn't the final attempt, it should only print with an INFO loglevel or maybe just not get printed at all (unless `header` is non-empty, maybe?). This will cut back on junk lines being included in Treeherder's failure summary tab, while still giving Fennec/tooling people the debugging information they need to actually fix these issues.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Bug 1509614 - Downgrade the loglevel for the `get_process_list()` messages in mozbase r?gbrown,bc

`get_process_list()` makes multiple attempts at setting up adb, but errors setting up the connection get logged with a loglevel of ERROR. This patch makes these messages print with a loglevel of INFO unless this is the final attempt. This will cut down on superfluous error messages appearing in Treeherder's logviewer, while still providing all of the info fennec/tooling developers would need to fix the underlying problem here.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5120b8ce3de8
Downgrade the loglevel for the `get_process_list()` messages in mozbase r=bc

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5120b8ce3de8