Closed
Bug 1509324
Opened 6 years ago
Closed 6 years ago
Android 7.0 x86 wpt intermittent | ERROR - adb get_process_list:
Categories
(Testing :: web-platform-tests, defect, P1)
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.07 KB,
patch
|
KWierso
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/logviewer.html#?job_id=213332123&repo=try&lineNumber=3087
[task 2018-11-22T05:56:27.410Z] 05:56:27 INFO - TEST-OK | /fetch/corb/style-html-correctly-labeled.sub.html | took 204ms
[task 2018-11-22T05:56:28.193Z] 05:56:28 ERROR - adb get_process_list:
[task 2018-11-22T05:56:28.534Z] 05:56:28 INFO - Browser exited with return code 0
Assignee | ||
Comment 1•6 years ago
|
||
There are several issues to look into here:
I think this hits wpt (I haven't seen any such failures in other test suites) because the wpt "Fennec browser" polls the returncode property, which in turn calls process_exist/get_process_list.
The error handling is suspect: Odd that no ADBError/ADBTimeoutError is reported. We could possibly surface such an error to trigger retry. (Or expand the retry list to include "adb get_process_list"?)
And why/how is get_process_list failing in the first place?
Assignee | ||
Updated•6 years ago
|
Keywords: intermittent-failure
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•6 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #1)
> The error handling is suspect: Odd that no ADBError/ADBTimeoutError is
> reported. We could possibly surface such an error to trigger retry. (Or
> expand the retry list to include "adb get_process_list"?)
Now addressed by bug 1509614.
> And why/how is get_process_list failing in the first place?
It is a known problem observed for some time in bug 1466657.
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 6•6 years ago
|
||
I hope that bug 1512686 will reduce the complexity of each check for process existence -- less adb traffic and parsing, fewer process table lookups, less opportunity for failure.
Assignee | ||
Comment 7•6 years ago
|
||
It seems like these errors happen more frequently when we poll frequently for process existence. 0.1 seconds seems too short to me - I'll feel better if we increase it like this, to 0.5 seconds.
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=20c4becb37e5999405bb11fcd885c8008cbaa122
Attachment #9030048 -
Flags: review?(wkocher)
Comment on attachment 9030048 [details] [diff] [review]
increase poll interval - poll less often
Worth a shot, at least.
Attachment #9030048 -
Flags: review?(wkocher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc5f0fb59ada
Poll remote process less often during startup and shutdown; r=kwierso
Comment 10•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•