Android 7.0 x86 wpt intermittent | ERROR - adb get_process_list:

RESOLVED FIXED in Firefox 66

Status

defect
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

({intermittent-failure})

Version 3
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

https://treeherder.mozilla.org/logviewer.html#?job_id=213332123&repo=try&lineNumber=3087

[task 2018-11-22T05:56:27.410Z] 05:56:27     INFO - TEST-OK | /fetch/corb/style-html-correctly-labeled.sub.html | took 204ms
[task 2018-11-22T05:56:28.193Z] 05:56:28    ERROR - adb get_process_list: 
[task 2018-11-22T05:56:28.534Z] 05:56:28     INFO - Browser exited with return code 0
There are several issues to look into here:

I think this hits wpt (I haven't seen any such failures in other test suites) because the wpt "Fennec browser" polls the returncode property, which in turn calls process_exist/get_process_list.

The error handling is suspect: Odd that no ADBError/ADBTimeoutError is reported. We could possibly surface such an error to trigger retry. (Or expand the retry list to include "adb get_process_list"?)

And why/how is get_process_list failing in the first place?
See Also: → 1466657, 1509614
Blocks: 1425322
(In reply to Geoff Brown [:gbrown] from comment #1)
> The error handling is suspect: Odd that no ADBError/ADBTimeoutError is
> reported. We could possibly surface such an error to trigger retry. (Or
> expand the retry list to include "adb get_process_list"?)

Now addressed by bug 1509614.
 
> And why/how is get_process_list failing in the first place?

It is a known problem observed for some time in bug 1466657.
Depends on: 1512686
Priority: -- → P1
I hope that bug 1512686 will reduce the complexity of each check for process existence -- less adb traffic and parsing, fewer process table lookups, less opportunity for failure.
It seems like these errors happen more frequently when we poll frequently for process existence. 0.1 seconds seems too short to me - I'll feel better if we increase it like this, to 0.5 seconds.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=20c4becb37e5999405bb11fcd885c8008cbaa122
Attachment #9030048 - Flags: review?(wkocher)
Comment on attachment 9030048 [details] [diff] [review]
increase poll interval - poll less often

Worth a shot, at least.
Attachment #9030048 - Flags: review?(wkocher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc5f0fb59ada
Poll remote process less often during startup and shutdown; r=kwierso
https://hg.mozilla.org/mozilla-central/rev/cc5f0fb59ada
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.