Closed Bug 1509930 Opened 2 years ago Closed 2 years ago

Simplify CycleCollectWithLogs's lifetime

Categories

(Core :: IPC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: nika, Assigned: nika)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This avoids conflating XPCOM listener lifetime with the actor's lifetime
Previously this actor would call `Send__delete__` in its destructor, meaning
that the lifetime of the actor is a bit hard to follow. This changes the actor
to instead use a separate object for XPCOM, and use refcounting universally.
This should also help with the transition to universally refcounted actors.
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bce195f98895
Simplify CycleCollectWithLogsChild's lifetime, r=jld
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a06e4cff09e6
Simplify CycleCollectWithLogsChild's lifetime, r=jld
https://hg.mozilla.org/mozilla-central/rev/a06e4cff09e6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Flags: needinfo?(nika)
You need to log in before you can comment on or make changes to this bug.