Closed Bug 1509930 Opened 10 months ago Closed 10 months ago
Collect With Logs's lifetime
47 bytes, text/x-phabricator-request
|Details | Review|
This avoids conflating XPCOM listener lifetime with the actor's lifetime
Previously this actor would call `Send__delete__` in its destructor, meaning that the lifetime of the actor is a bit hard to follow. This changes the actor to instead use a separate object for XPCOM, and use refcounting universally. This should also help with the transition to universally refcounted actors.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bce195f98895 Simplify CycleCollectWithLogsChild's lifetime, r=jld
Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426, bug 1500949, bug 1487249, bug 1509930, bug 1500950, bug 1500944) for causing crashes and assertion failures on PBackgroundParent.cpp:696 CLOSED TREE Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfe29337ffe3d93cd060077e2e999e72bb9b7cf Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214255312&revision=c3fe435e473a463fbc22d4afa531bdedb757079c Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=214255312&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=214255794&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=214249038&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=214249630&repo=mozilla-inbound :Nika Layzell Could you please take a look?
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a06e4cff09e6 Simplify CycleCollectWithLogsChild's lifetime, r=jld
You need to log in before you can comment on or make changes to this bug.