150994 - iframe with tabindex shortens tab cycle

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Jesse Ruderman]

The Hotmail "welcome" page has an iframe with a tabindex.  It's not possible to
get to any link beyond the iframe using the tab key.

Tab:
Links above iframe -> Iframe content area -> Iframe content.  (Skips links below
iframe, content area, location bar.)

Shift+Tab:
Links below iframe -> Iframe content -> Iframe content area -> Content area ->
Location bar.  (Skips links above iframe.)

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Aaron Leventhal]

Sorry bryner

Comment 3

[Kyle Yuan]

Attachment: don't get tabindex for element that don't support it

see: http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex
only A, AREA, BUTTON, INPUT, OBJECT, SELECT, and TEXTAREA support tabindex
attribute. so we shouldn't get this for other elements.

Comment 4

[Aaron Leventhal]

Comment on attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

r=aaronl

Bryner, is this fix okay?

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

That may be true for HTML, but not for XUL.  Please do an IsContentOfType check
before checking the tag.

Comment 6

[Jesse Ruderman]

See also bug 171366, tabindex should work for anything focusable.

Comment 7

[Kyle Yuan]

Attachment: patch addressed bryner comment

Comment 8

[Aaron Leventhal]

Comment on attachment 110640 [details] [diff] [review]
patch addressed bryner comment

r=aaronl

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 110640 [details] [diff] [review]
patch addressed bryner comment

sr=bryner

Comment 10

[Kyle Yuan]

taking...

Comment 11

[Kyle Yuan]

checked in!

Comment 12

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.01.13.08 comm trunk bits. tested with testcase on linxu
rh8.0, win2k and mac 10.2.3.