iframe with tabindex shortens tab cycle

VERIFIED FIXED

Status

()

Core
Keyboard: Navigation
--
major
VERIFIED FIXED
16 years ago
15 years ago

People

(Reporter: Jesse Ruderman, Assigned: Kyle Yuan)

Tracking

(Blocks: 1 bug, {access})

Trunk
x86
Windows 2000
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

651 bytes, text/html
Details
980 bytes, patch
Aaron Leventhal
: review+
Brian Ryner (not reading)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
The Hotmail "welcome" page has an iframe with a tabindex.  It's not possible to
get to any link beyond the iframe using the tab key.

Tab:
Links above iframe -> Iframe content area -> Iframe content.  (Skips links below
iframe, content area, location bar.)

Shift+Tab:
Links below iframe -> Iframe content -> Iframe content area -> Content area ->
Location bar.  (Skips links above iframe.)
(Reporter)

Comment 1

16 years ago
Created attachment 87274 [details]
testcase

Comment 2

16 years ago
Sorry bryner
Assignee: aaronl → bryner
Blocks: 83552
(Reporter)

Updated

16 years ago
Keywords: access
(Assignee)

Comment 3

15 years ago
Created attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

see: http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex
only A, AREA, BUTTON, INPUT, OBJECT, SELECT, and TEXTAREA support tabindex
attribute. so we shouldn't get this for other elements.
(Assignee)

Updated

15 years ago
Attachment #109627 - Flags: review?(aaronl)

Comment 4

15 years ago
Comment on attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

r=aaronl

Bryner, is this fix okay?
Attachment #109627 - Flags: superreview?(bryner)
Attachment #109627 - Flags: review?(aaronl)
Attachment #109627 - Flags: review+
Comment on attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

That may be true for HTML, but not for XUL.  Please do an IsContentOfType check
before checking the tag.
Attachment #109627 - Flags: superreview?(bryner) → superreview-
(Reporter)

Comment 6

15 years ago
See also bug 171366, tabindex should work for anything focusable.
(Assignee)

Comment 7

15 years ago
Created attachment 110640 [details] [diff] [review]
patch addressed bryner comment
Attachment #109627 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #110640 - Flags: superreview?(bryner)
Attachment #110640 - Flags: review?(aaronl)

Comment 8

15 years ago
Comment on attachment 110640 [details] [diff] [review]
patch addressed bryner comment

r=aaronl
Attachment #110640 - Flags: review?(aaronl) → review+
Comment on attachment 110640 [details] [diff] [review]
patch addressed bryner comment

sr=bryner
Attachment #110640 - Flags: superreview?(bryner) → superreview+
(Assignee)

Comment 10

15 years ago
taking...
Assignee: bryner → kyle.yuan
(Assignee)

Comment 11

15 years ago
checked in!
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2003.01.13.08 comm trunk bits. tested with testcase on linxu
rh8.0, win2k and mac 10.2.3.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.